BIND 10 trac1329, updated. 27b7f9d36113514773777eb94bf66a3ef8c49a82 [1329] clarified that getRecordDiff must be replaced with the official one later and that some details are intentionally ignored.

[BIND 10 source code commits]

The branch, trac1329 has been updated
       via  27b7f9d36113514773777eb94bf66a3ef8c49a82 (commit)
       via  6716721a7c10737d86a4a29af530d54a458f83ca (commit)
       via  e8aa8b8b994146dfff6d29435a66c88dcf79eb69 (commit)
      from  dee6a4739aee15e8899da2e35d179cb1d8623e76 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 27b7f9d36113514773777eb94bf66a3ef8c49a82
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Nov 4 10:40:27 2011 -0700

    [1329] clarified that getRecordDiff must be replaced with the official one
    later and that some details are intentionally ignored.

commit 6716721a7c10737d86a4a29af530d54a458f83ca
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Nov 4 10:36:07 2011 -0700

    [1329] add note that handling diffs is optional and NotImplemented will
    be thrown on addRecordDiff() in such a case.

commit e8aa8b8b994146dfff6d29435a66c88dcf79eb69
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Nov 4 10:03:38 2011 -0700

    [1329] comment style consistency

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/database.h         |   14 +++++++++++---
 src/lib/datasrc/sqlite3_accessor.h |    9 +++++++--
 2 files changed, 18 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/database.h b/src/lib/datasrc/database.h
index 8f38e8e..b9379b7 100644
--- a/src/lib/datasrc/database.h
+++ b/src/lib/datasrc/database.h
@@ -113,9 +113,11 @@ public:
         DEL_PARAM_COUNT = 3 ///< Number of parameters
     };
 
-    /// Operation mode when adding a record diff.
-    ///
-    /// This is used as the "operation" parameter value of addRecordDiff().
+    /**
+     * Operation mode when adding a record diff.
+     *
+     * This is used as the "operation" parameter value of addRecordDiff().
+     */
     enum DiffOperation {
         DIFF_ADD = 0,           ///< This diff is for adding an RR
         DIFF_DELETE = 1         ///< This diff is for deleting an RR
@@ -532,9 +534,15 @@ public:
     /// a single zone.  For this possible extension \c zone_id parameter is
     /// included even if it's redundant under the current restriction.
     ///
+    /// The support for adding (or retrieving) diffs is optional; if it's
+    /// not supported in a specific data source, this method for the
+    /// corresponding derived class will throw an \c NotImplemented exception.
+    ///
     /// \exception DataSourceError Invalid call without starting a transaction,
     /// zone ID doesn't match the zone being updated, or other internal
     /// database error.
+    /// \exception NotImplemented Adding diffs is not supported in the
+    /// data source.
     /// \exception Other The concrete derived method may throw other
     /// data source specific exceptions.
     ///
diff --git a/src/lib/datasrc/sqlite3_accessor.h b/src/lib/datasrc/sqlite3_accessor.h
index 910d835..6b5369c 100644
--- a/src/lib/datasrc/sqlite3_accessor.h
+++ b/src/lib/datasrc/sqlite3_accessor.h
@@ -165,8 +165,13 @@ public:
         const std::string (&params)[DIFF_PARAM_COUNT]);
 
     // A short term method for tests until we implement more complete
-    // API to retrieve diffs.  It returns all records of the diffs table
-    // whose zone_id column is identical to the given value.
+    // API to retrieve diffs (#1330).  It returns all records of the diffs
+    // table whose zone_id column is identical to the given value.
+    // Since this is a short term workaround, it ignores some corner cases
+    // (such as an SQLite3 execution failure) and is not very efficient,
+    // in favor of brevity.  Once #1330 is completed, this method must be
+    // removed, and the tests using this method must be rewritten using the
+    // official API.
     std::vector<std::vector<std::string> > getRecordDiff(int zone_id);
 
     /// The SQLite3 implementation of this method returns a string starting