BIND 10 master, updated. d0e0bab2c4e3ce4f60c893d3a89ec8c91e2f11e0 [master] skipped DataSrcClient.test_iterate for now; it seems to assume a specific order of the underlying datasrc SQLite3 query result, but it doesn't appear to be the case for all systems.

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Nov 10 18:12:12 UTC 2011


The branch, master has been updated
       via  d0e0bab2c4e3ce4f60c893d3a89ec8c91e2f11e0 (commit)
      from  46c4fc8c240445d0d7cb70a0b5ae17eff371c5db (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d0e0bab2c4e3ce4f60c893d3a89ec8c91e2f11e0
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 10 10:09:03 2011 -0800

    [master] skipped DataSrcClient.test_iterate for now; it seems to assume
    a specific order of the underlying datasrc SQLite3 query result, but it
    doesn't appear to be the case for all systems.
    
    (I made a couple of piggy-back small fix/cleanup: avoid unexpected exception
    in an assert failure message for an empty (test) RRset; suppress log output
    (by default))

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/datasrc/tests/datasrc_test.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/datasrc/tests/datasrc_test.py b/src/lib/python/isc/datasrc/tests/datasrc_test.py
index 2e83375..68e075a 100644
--- a/src/lib/python/isc/datasrc/tests/datasrc_test.py
+++ b/src/lib/python/isc/datasrc/tests/datasrc_test.py
@@ -82,6 +82,7 @@ class DataSrcClient(unittest.TestCase):
                           isc.datasrc.DataSourceClient, "memory",
                           "{ \"foo\": 1 }")
 
+    @unittest.skip("This test may fail depending on sqlite3 library behavior")
     def test_iterate(self):
         dsc = isc.datasrc.DataSourceClient("sqlite3", READ_ZONE_DB_CONFIG)
 
@@ -181,7 +182,9 @@ class DataSrcClient(unittest.TestCase):
         # Now check there are none left
         self.assertEqual(0, len(expected_rrset_list),
                          "RRset(s) not returned by iterator: " +
-                         str([rrset.to_text() for rrset in expected_rrset_list ]
+                         str([rrset.get_name().to_text() + '/' +
+                              rrset.get_type().to_text() for rrset in
+                              expected_rrset_list ]
                         ))
 
         # TODO should we catch this (iterating past end) and just return None
@@ -564,4 +567,5 @@ class DataSrcUpdater(unittest.TestCase):
 
 if __name__ == "__main__":
     isc.log.init("bind10")
+    isc.log.resetUnitTestRootLogger()
     unittest.main()




More information about the bind10-changes mailing list