BIND 10 trac1333r, updated. c0cc183880fc5e1949bcc97585c20ac2ab21e281 [1333r] added comment about why we need to clear some JournalRead attributes in tearDown.

[BIND 10 source code commits]

The branch, trac1333r has been updated
       via  c0cc183880fc5e1949bcc97585c20ac2ab21e281 (commit)
       via  2d85e22f10321fbc5b9cd12f70e90907cb01830f (commit)
      from  7344d2788cd06e54ca7ca3e3a3f69010dac80670 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0cc183880fc5e1949bcc97585c20ac2ab21e281
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Nov 18 09:11:54 2011 -0800

    [1333r] added comment about why we need to clear some JournalRead attributes
    in tearDown.

commit 2d85e22f10321fbc5b9cd12f70e90907cb01830f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Nov 18 09:07:35 2011 -0800

    [1333r] removed commented-out macro setting.  it was left in case we'll
    need it in a future version, but as it was explicitly pointed out in review
    it's probably less confusing to remove it completely.

-----------------------------------------------------------------------

Summary of changes:
 .../python/isc/datasrc/journal_reader_python.cc    |    4 ----
 src/lib/python/isc/datasrc/tests/datasrc_test.py   |    5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/datasrc/journal_reader_python.cc b/src/lib/python/isc/datasrc/journal_reader_python.cc
index 28e4b40..ff398d1 100644
--- a/src/lib/python/isc/datasrc/journal_reader_python.cc
+++ b/src/lib/python/isc/datasrc/journal_reader_python.cc
@@ -12,10 +12,6 @@
 // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
 // PERFORMANCE OF THIS SOFTWARE.
 
-// Enable this if you use s# variants with PyArg_ParseTuple(), see
-// http://docs.python.org/py3k/c-api/arg.html#strings-and-buffers
-//#define PY_SSIZE_T_CLEAN
-
 // Python.h needs to be placed at the head of the program file, see:
 // http://docs.python.org/py3k/extending/extending.html#a-simple-example
 #include <Python.h>
diff --git a/src/lib/python/isc/datasrc/tests/datasrc_test.py b/src/lib/python/isc/datasrc/tests/datasrc_test.py
index 6c969c2..09a404e 100644
--- a/src/lib/python/isc/datasrc/tests/datasrc_test.py
+++ b/src/lib/python/isc/datasrc/tests/datasrc_test.py
@@ -694,6 +694,11 @@ class JournalRead(unittest.TestCase):
         self.reader = None
 
     def tearDown(self):
+        # Some test leaves the reader in the middle of sequence, holding
+        # the lock.  Since the unittest framework keeps each test object
+        # until the end of the entire tests, we need to make sure the reader
+        # is released at the end of each test.  The client shouldn't do harm
+        # but we clean it up, too, just in case.
         self.dsc = None
         self.reader = None