BIND 10 trac1238, updated. a26b979adb54baabdf939ed1a7852b2ee9b8b93c [1238] Fix in sockets6 test (now passes on Mac OS X)

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Nov 30 18:37:43 UTC 2011


The branch, trac1238 has been updated
       via  a26b979adb54baabdf939ed1a7852b2ee9b8b93c (commit)
      from  cbe600decbef4db82cb3b070e03b5702540af4aa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a26b979adb54baabdf939ed1a7852b2ee9b8b93c
Author: Tomek Mrugalski <tomasz at isc.org>
Date:   Wed Nov 30 19:37:22 2011 +0100

    [1238] Fix in sockets6 test (now passes on Mac OS X)

-----------------------------------------------------------------------

Summary of changes:
 src/bin/dhcp6/tests/iface_mgr_unittest.cc |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/dhcp6/tests/iface_mgr_unittest.cc b/src/bin/dhcp6/tests/iface_mgr_unittest.cc
index 67e0ed6..3cc2ae8 100644
--- a/src/bin/dhcp6/tests/iface_mgr_unittest.cc
+++ b/src/bin/dhcp6/tests/iface_mgr_unittest.cc
@@ -264,21 +264,11 @@ TEST_F(IfaceMgrTest, sockets6) {
     int socket2 = ifacemgr->openSocket(LOOPBACK, loAddr, 10548);
     EXPECT_GT(socket2, 0);
 
-    // expect success. This address/port is already bound, but
-    // we are using SO_REUSEADDR, so we can bind it twice
-    int socket3 = ifacemgr->openSocket(LOOPBACK, loAddr, 10547);
-
-    // rebinding succeeds on Linux, fails on BSD
-    // TODO: add OS-specific defines here (or modify code to
-    // behave the same way on all OSes, but that may not be
-    // possible
-    // EXPECT_GT(socket3, 0); // socket > 0
-
-    // we now have 3 sockets open at the same time. Looks good.
+    // removed code for binding socket twice to the same address/port
+    // as it caused problems on some platforms (e.g. Mac OS X)
 
     close(socket1);
     close(socket2);
-    close(socket3);
 
     delete ifacemgr;
 }




More information about the bind10-changes mailing list