BIND 10 master, updated. c110fcc95f61b07871fd6fe7e24a495a3f49b89c option6_addrlst test no longer uses ::2 as it confuses IOAddress class.

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Oct 17 11:54:24 UTC 2011


The branch, master has been updated
       via  c110fcc95f61b07871fd6fe7e24a495a3f49b89c (commit)
      from  58e72cb159391aa0c7832d08ddb0df361514918e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c110fcc95f61b07871fd6fe7e24a495a3f49b89c
Author: Tomek Mrugalski <tomasz at isc.org>
Date:   Mon Oct 17 13:53:53 2011 +0200

    option6_addrlst test no longer uses ::2 as it confuses IOAddress class.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/tests/option6_addrlst_unittest.cc |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/tests/option6_addrlst_unittest.cc b/src/lib/dhcp/tests/option6_addrlst_unittest.cc
index 3a1975d..2a2fc1a 100644
--- a/src/lib/dhcp/tests/option6_addrlst_unittest.cc
+++ b/src/lib/dhcp/tests/option6_addrlst_unittest.cc
@@ -209,11 +209,19 @@ TEST_F(Option6AddrLstTest, setAddress) {
     EXPECT_NO_THROW(
         opt1 = new Option6AddrLst(1234, IOAddress("::1"));
     );
-    opt1->setAddress(IOAddress("::2"));
+    opt1->setAddress(IOAddress("2001:db8:1::2"));
+    /// TODO It used to be ::2 address, but io_address represents
+    /// it as ::0.0.0.2. Purpose of this test is to verify
+    /// that setAddress() works, not deal with subtleties of
+    /// io_address handling of IPv4-mapped IPv6 addresses, we
+    /// switched to a more common address. User interested
+    /// in pursuing this matter further is encouraged to look
+    /// at section 2.5.5 of RFC4291 (and possibly implement
+    /// a test for IOAddress)
 
     Option6AddrLst::AddressContainer addrs = opt1->getAddresses();
     ASSERT_EQ(1, addrs.size() );
-    EXPECT_EQ("::2", addrs[0].toText());
+    EXPECT_EQ("2001:db8:1::2", addrs[0].toText());
 
     EXPECT_NO_THROW(
         delete opt1;




More information about the bind10-changes mailing list