BIND 10 trac1305, updated. 9ebdb058e61cae1dda642fcb00ced7b7554b44fb [1305] fixed typo in comments

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Oct 18 16:27:24 UTC 2011


The branch, trac1305 has been updated
       via  9ebdb058e61cae1dda642fcb00ced7b7554b44fb (commit)
       via  b88c94b7119650217408d800847dfbbbcea7306c (commit)
       via  419b9d48771946a1b0b75b7412cd2da3e7f81a5a (commit)
      from  acab4a018b927cf5887b6de8135dbae0d2dcdbff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9ebdb058e61cae1dda642fcb00ced7b7554b44fb
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Oct 18 09:27:06 2011 -0700

    [1305] fixed typo in comments

commit b88c94b7119650217408d800847dfbbbcea7306c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Oct 18 09:25:33 2011 -0700

    [1305] improved comment wording

commit 419b9d48771946a1b0b75b7412cd2da3e7f81a5a
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Oct 18 09:24:13 2011 -0700

    [1305] removed an unnecessary condition check

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/database.cc                |    7 ++++---
 src/lib/datasrc/tests/database_unittest.cc |    2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/database.cc b/src/lib/datasrc/database.cc
index c0decd4..d35f6e8 100644
--- a/src/lib/datasrc/database.cc
+++ b/src/lib/datasrc/database.cc
@@ -509,9 +509,10 @@ DatabaseClient::Finder::find(const isc::dns::Name& name,
                 records_found = true;
                 get_cover = dnssec_data;
             } else if ((options & NO_WILDCARD) != 0) {
-                // If wildcard check is disabled, terminate the search with
-                // NXDOMAIN.
-                if (dnssec_data && !records_found) {
+                // If wildcard check is disabled, the search will ultimately
+                // terminate with NXDOMAIN. If DNSSEC is enabled, flag that
+                // we need to get the NSEC records to prove this.
+                if (dnssec_data) {
                     get_cover = true;
                 }
             } else {
diff --git a/src/lib/datasrc/tests/database_unittest.cc b/src/lib/datasrc/tests/database_unittest.cc
index d6a9689..de6b5fa 100644
--- a/src/lib/datasrc/tests/database_unittest.cc
+++ b/src/lib/datasrc/tests/database_unittest.cc
@@ -1619,7 +1619,7 @@ TYPED_TEST(DatabaseClientTest, wildcard) {
                    this->expected_rdatas_, this->expected_sig_rdatas_);
     }
 
-    // With FIND_DNSSEC, it should result in WILDCARD_EMPTY.
+    // With FIND_DNSSEC, it should result in WILDCARD_NXRRSET.
     const char* negative_dnssec_names[] = {
         "a.bar.example.org.",
         "foo.baz.bar.example.org.",




More information about the bind10-changes mailing list