BIND 10 trac1175, updated. 6078f59be7a52823ba846b57dfdf5555a994ae01 [1175] - move up an assignment of the BIND10_MSGQ_SOCKET_FILE environment variable (BaseModules uses a constant file name during each testcase) - BaseModules checks whether msgq is ready after it started the msgq object. A SessionTimeout is raised here if not.

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Sep 12 06:52:55 UTC 2011 

The branch, trac1175 has been updated
  discards  3f70cdcd8eb249f181ef476efc6ba318222761e7 (commit)
  discards  31e04a17289ee2687466591b9df964a9659a375e (commit)
  discards  4b6daaaa8d2a5e0dbf8210c21dad131029009c43 (commit)
  discards  90de4c4e4fb6b662e9da3ee0dcbae2e54fe2e992 (commit)
  discards  d0ad5620c23f7979af4f6aadda2383cad940b8a7 (commit)
  discards  bb74e48c48ba3743a3dcc6d907835112fce92def (commit)
  discards  0076f83b0dc170cc806f5991f3f36458e0bbb242 (commit)
  discards  9ca1103b1578485a4c04f1bbc2d91a7b4ec2ee09 (commit)
  discards  0f462b5a992b398fdfb908b7b5555b6ba484a9bb (commit)
  discards  f85390bf443c2a2c3d95f0c5c82a2070c636c57b (commit)
  discards  b20929fe294591f30dfb7bf2a40c2edd9bfc45f6 (commit)
  discards  ff28ef8e9fb8cb68a3f58a85e2744692964cefa4 (commit)
  discards  d8c47010e3fd5d291dbb3f427300257f07d63e24 (commit)
  discards  20c91f9803ce27454ff5c6af744c0fba8cf002c0 (commit)
  discards  ff74c405731bf02ee6132f473029d8b71ff71c19 (commit)
  discards  643270555fc44684fc0594b4aee85ca6e22f511d (commit)
  discards  68928e70b776e8ae394e1d0e21b8bace3ceda2ef (commit)
  discards  3a0c4b465bb37c177b319ad4b4dd2c57b1b799a9 (commit)
  discards  d718ed58d4d4ab2d2bfc63a184f0e8066809d113 (commit)
  discards  dffa1540f85282c35acbab03aec17a2bbe0f67c4 (commit)
  discards  2070a8162567d0b5ddd60e548063a926d3ae8f1f (commit)
  discards  116c8de3d0ca86ad0f1a59a0afcf36a266d7f66f (commit)
  discards  4946bf927003dec032d6c11ca42827b1e011705f (commit)
       via  6078f59be7a52823ba846b57dfdf5555a994ae01 (commit)
       via  7c202b7e46a65b1bf7057e1e6c2752d2a6c98b9a (commit)
       via  38c065e11720d711bc004672faaf5db3a56e84be (commit)
       via  291f0f2f084d8d4c0e49d5b29c60a069c3dea48b (commit)
       via  7b7a35888f23c22e7548f688071af250136cb6ef (commit)
       via  83194b22eb8aaa1847b96b8211ec9086df8ceca2 (commit)
       via  7c22e0beadb85a925a2e62e79d7f08b17c7d720f (commit)
       via  b2d680ae7538010ea304d4152987d53371efcd4e (commit)
       via  eef34f4aa11c8ceb5c37620a8552000af538538a (commit)
       via  ccba0dab0107b0d709c0506357c194822644552e (commit)
       via  594ed61597938cf99b99a2a5d97eeedbbbb47669 (commit)
       via  71a537d3ddacba164dc88b3dcc9b6cee3dea8709 (commit)
       via  0c386a2816aac29e65460068f4fb165e30095a57 (commit)
       via  4770d9ef2d3ffa89b6995e22dbd1d5f6674d50bb (commit)
       via  323b91f3b04deb985cefc06e08f1192b6dad6417 (commit)
       via  05e0aa4a0a4158d290b7d1357d6fb5877c9d6a6e (commit)
       via  05173b91c3688bbc402bf71af6155985dcc4a6e6 (commit)
       via  1d51eecb1ba126b123f31502347d7276e9f7863b (commit)
       via  73ef6f968a3d19c30e5cec71f6e5e88a4b9afa71 (commit)
       via  bc912575b70e26e730fa705f07259a39bea9a6f9 (commit)
       via  0d25243709b1d318b41efa0e9ba7c24fe48f7fe4 (commit)
       via  f7ddf104ef809e0b204bfa992146535a05a344c4 (commit)
       via  02b2e71bdc1564f4272869bb5676727af809870f (commit)
       via  8d1942a3b7516e8161b7f54888da2a4a4d27484e (commit)
       via  856ff83ad2b97c136de1103a421547bdcb332e74 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (3f70cdcd8eb249f181ef476efc6ba318222761e7)
            \
             N -- N -- N (6078f59be7a52823ba846b57dfdf5555a994ae01)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6078f59be7a52823ba846b57dfdf5555a994ae01
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Thu Sep 8 10:52:19 2011 +0900

    [1175]
     - move up an assignment of the BIND10_MSGQ_SOCKET_FILE environment variable
       (BaseModules uses a constant file name during each testcase)
     - BaseModules checks whether msgq is ready after it started the msgq object.
       A SessionTimeout is raised here if not.

commit 7c202b7e46a65b1bf7057e1e6c2752d2a6c98b9a
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Tue Sep 6 20:27:44 2011 +0900

    [1175] fix a typo

commit 38c065e11720d711bc004672faaf5db3a56e84be
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Tue Sep 6 20:17:57 2011 +0900

    [1175]
     - The function get_availaddr uses socket.getaddrinfo for getting the address
       family.
     - The function is_ipv6_enabled uses 3 random ports for checking whether IPv6
       is enabled.

commit 291f0f2f084d8d4c0e49d5b29c60a069c3dea48b
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Tue Sep 6 11:42:42 2011 +0900

    [1175] send the command 'status' to the stats when it started, and then send
           the command 'shutdown', and also check each value returned by each
           invoked command

commit 7b7a35888f23c22e7548f688071af250136cb6ef
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Sep 5 17:14:11 2011 +0900

    [1175]
     - The stats httpd doesn't need to return an argument when it's shutting down.
     - The testcase sends the 'status' command or the 'shutdown' command to the
       stats or the stats httpd when they started, and then their returned values
       are checked.

commit 83194b22eb8aaa1847b96b8211ec9086df8ceca2
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Sep 5 05:01:18 2011 +0000

    [1175]
     - add 3-time retry to creating the server object when it fails in the
       ThreadingServerManager class
     - suppress outputs by Msgq, and add dummy sys module and the output
       methods
     - pass Exceptions raised while it's running with a thread

commit 7c22e0beadb85a925a2e62e79d7f08b17c7d720f
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Sep 5 04:53:24 2011 +0000

    [1175] remove a logging name from unittest

commit b2d680ae7538010ea304d4152987d53371efcd4e
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Sep 5 04:53:11 2011 +0000

    [1175]
     - remove a logging name from unittest
     - do stats_httpd.stop() in teadDown() instead of each test case
     - send 'shutdown' command to kill stats_httpd when testing address already in use

commit eef34f4aa11c8ceb5c37620a8552000af538538a
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Sep 5 04:46:08 2011 +0000

    [1175] remove -v option from pycoverage

commit ccba0dab0107b0d709c0506357c194822644552e
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Thu Sep 1 11:34:28 2011 +0000

    [1175] add -v option in pycoverage for debugging the failure in buildbot.
    (unittest.main() with verbosity option is not supported in Python3.1.)

commit 594ed61597938cf99b99a2a5d97eeedbbbb47669
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Thu Sep 1 04:19:53 2011 +0000

    [1175]
     - more strictly close the io object whether it's successfully opened or not
     - add verbosity=2 in unittest.main for debugging the failure in the buildbot
     - don't redict sys.stderr in MockMsgq
     - rename the function name to create_specfile
     - switch the verbose in Msgq into True

commit 71a537d3ddacba164dc88b3dcc9b6cee3dea8709
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Fri Aug 26 12:01:47 2011 +0900

    [1175] fix wrong list-type handling in the function get_spec_defaults and add
    more tests into test_get_spec_defaults

commit 0c386a2816aac29e65460068f4fb165e30095a57
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Wed Aug 24 17:28:29 2011 +0900

    [1175] fix typo and correct changes from trac519

commit 4770d9ef2d3ffa89b6995e22dbd1d5f6674d50bb
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Wed Aug 24 16:51:11 2011 +0900

    [1175] deadlock will be killed afer 20 secs

commit 323b91f3b04deb985cefc06e08f1192b6dad6417
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Wed Aug 24 15:55:21 2011 +0900

    [1175] fix conflicts with trac519

commit 05e0aa4a0a4158d290b7d1357d6fb5877c9d6a6e
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Tue Aug 23 16:42:18 2011 +0900

    [1175]
     - A hostname (canonical name of host) is not acceptable in listen_on
       configuration.
     - A default port number(starting number for search) is added in args of the
       function get_availaddr.

commit 05173b91c3688bbc402bf71af6155985dcc4a6e6
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Tue Aug 23 11:22:03 2011 +0900

    [1175] set msgq verbose off

commit 1d51eecb1ba126b123f31502347d7276e9f7863b
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Aug 22 18:20:39 2011 +0900

    [1175] add #1175

commit 73ef6f968a3d19c30e5cec71f6e5e88a4b9afa71
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Aug 22 18:18:47 2011 +0900

    [1175]
    - don't use time.sleep for waiting threads are starting or finishing
    - correct shutting down of mock modules
    - use _started (threading.Event) where command_handler is invoked
    - add implementation to changing contents of specfile of MyStatsHttpd
    - set "BIND10_MSGQ_SOCKET_FILE" only when it's not set yet

commit bc912575b70e26e730fa705f07259a39bea9a6f9
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Aug 22 18:10:25 2011 +0900

    [1175]
    - add function get_availaddr to get available address and port on the platform
    - add function is_ipv6enabled to check ipv6 enabled on the platform
    - add miscellaneous changes to refactor unittest

commit 0d25243709b1d318b41efa0e9ba7c24fe48f7fe4
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Mon Aug 22 18:05:57 2011 +0900

    [1175]
    - don't use DEFAULT_CONFIG
    - move up mccs.start and open_httpd to __init__(). It takes time to do these
    functions, and an extra sleep is needed in unittests.
    - set running to False in http stopping
    - use validate_config in module_spec class
    - don't close/open http before it's opened

commit f7ddf104ef809e0b204bfa992146535a05a344c4
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Wed Aug 17 13:37:45 2011 +0900

    Revert "[master] Revert trac930 because of failures on biuldbots:"
    
    This reverts commit 5de7909a21a077238567b64e489ed5345824b2a0.
    
    Conflicts:
    
    	ChangeLog

-----------------------------------------------------------------------

Summary of changes:
 src/bin/stats/tests/test_utils.py          |   12 +------
 src/bin/xfrin/b10-xfrin.8                  |    6 ++--
 src/bin/xfrin/b10-xfrin.xml                |    4 +-
 src/lib/datasrc/tests/testdata/Makefile.am |    3 +-
 src/lib/datasrc/zone.h                     |   51 +++++++++++----------------
 5 files changed, 29 insertions(+), 47 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/stats/tests/test_utils.py b/src/bin/stats/tests/test_utils.py
index 15af1f8..20b959e 100644
--- a/src/bin/stats/tests/test_utils.py
+++ b/src/bin/stats/tests/test_utils.py
@@ -331,17 +331,7 @@ class BaseModules:
         self.msgq = ThreadingServerManager(MockMsgq)
         self.msgq.run()
         # Check whether msgq is ready. A SessionTimeout is raised here if not.
-        n = 0
-        while True:
-            try:
-                isc.cc.session.Session().close()
-            except isc.cc.session.SessionTimeout:
-                # retrying until 3 times
-                if n >2: raise
-                else:
-                    n = n + 1
-                    continue
-            else: break
+        isc.cc.session.Session().close()
         # MockCfgmgr
         self.cfgmgr = ThreadingServerManager(MockCfgmgr)
         self.cfgmgr.run()
diff --git a/src/bin/xfrin/b10-xfrin.8 b/src/bin/xfrin/b10-xfrin.8
index 7f73213..54dbe7c 100644
--- a/src/bin/xfrin/b10-xfrin.8
+++ b/src/bin/xfrin/b10-xfrin.8
@@ -2,12 +2,12 @@
 .\"     Title: b10-xfrin
 .\"    Author: [FIXME: author] [see http://docbook.sf.net/el/author]
 .\" Generator: DocBook XSL Stylesheets v1.75.2 <http://docbook.sf.net/>
-.\"      Date: May 19, 2011
+.\"      Date: September 8, 2011
 .\"    Manual: BIND10
 .\"    Source: BIND10
 .\"  Language: English
 .\"
-.TH "B10\-XFRIN" "8" "May 19, 2011" "BIND10" "BIND10"
+.TH "B10\-XFRIN" "8" "September 8, 2011" "BIND10" "BIND10"
 .\" -----------------------------------------------------------------
 .\" * set default formatting
 .\" -----------------------------------------------------------------
@@ -61,7 +61,7 @@ receives its configurations from
 .PP
 The configurable settings are:
 .PP
-\fItransfers\-in\fR
+\fItransfers_in\fR
 defines the maximum number of inbound zone transfers that can run concurrently\&. The default is 10\&.
 .PP
 
diff --git a/src/bin/xfrin/b10-xfrin.xml b/src/bin/xfrin/b10-xfrin.xml
index 17840fe..d45e15f 100644
--- a/src/bin/xfrin/b10-xfrin.xml
+++ b/src/bin/xfrin/b10-xfrin.xml
@@ -20,7 +20,7 @@
 <refentry>
 
   <refentryinfo>
-    <date>May 19, 2011</date>
+    <date>September 8, 2011</date>
   </refentryinfo>
 
   <refmeta>
@@ -92,7 +92,7 @@ in separate zonemgr process.
       The configurable settings are:
     </para>
 
-    <para><varname>transfers-in</varname>
+    <para><varname>transfers_in</varname>
       defines the maximum number of inbound zone transfers
       that can run concurrently. The default is 10.
     </para>
diff --git a/src/lib/datasrc/tests/testdata/Makefile.am b/src/lib/datasrc/tests/testdata/Makefile.am
index 84d49fc..64ae955 100644
--- a/src/lib/datasrc/tests/testdata/Makefile.am
+++ b/src/lib/datasrc/tests/testdata/Makefile.am
@@ -1,5 +1,6 @@
 CLEANFILES = *.copied
 BUILT_SOURCES = rwtest.sqlite3.copied
 
+# We use install-sh with the -m option to make sure it's writable
 rwtest.sqlite3.copied: $(srcdir)/rwtest.sqlite3
-	cp $(srcdir)/rwtest.sqlite3 $@
+	$(top_srcdir)/install-sh -m 644 $(srcdir)/rwtest.sqlite3 $@
diff --git a/src/lib/datasrc/zone.h b/src/lib/datasrc/zone.h
index 3e8b173..bb4f435 100644
--- a/src/lib/datasrc/zone.h
+++ b/src/lib/datasrc/zone.h
@@ -23,40 +23,31 @@
 namespace isc {
 namespace datasrc {
 
-/// \brief The base class for a single authoritative zone
+/// \brief The base class to search a zone for RRsets
 ///
-/// The \c Zone class is an abstract base class for representing
-/// a DNS zone as part of data source.
+/// The \c ZoneFinder class is an abstract base class for representing
+/// an object that performs DNS lookups in a specific zone accessible via
+/// a data source.  In general, different types of data sources (in-memory,
+/// database-based, etc) define their own derived classes of \c ZoneFinder,
+/// implementing ways to retrieve the required data through the common
+/// interfaces declared in the base class.  Each concrete \c ZoneFinder
+/// object is therefore (conceptually) associated with a specific zone
+/// of one specific data source instance.
 ///
-/// At the moment this is provided mainly for making the \c ZoneTable class
-/// and the authoritative query logic testable, and only provides a minimal
-/// set of features.
-/// This is why this class is defined in the same header file, but it may
-/// have to move to a separate header file when we understand what is
-/// necessary for this class for actual operation.
+/// The origin name and the RR class of the associated zone are available
+/// via the \c getOrigin() and \c getClass() methods, respectively.
 ///
-/// The idea is to provide a specific derived zone class for each data
-/// source, beginning with in memory one.  At that point the derived classes
-/// will have more specific features.  For example, they will maintain
-/// information about the location of a zone file, whether it's loaded in
-/// memory, etc.
+/// The most important method of this class is \c find(), which performs
+/// the lookup for a given domain and type.  See the description of the
+/// method for details.
 ///
-/// It's not yet clear how the derived zone classes work with various other
-/// data sources when we integrate these components, but one possibility is
-/// something like this:
-/// - If the underlying database such as some variant of SQL doesn't have an
-///   explicit representation of zones (as part of public interface), we can
-///   probably use a "default" zone class that simply encapsulates the
-///   corresponding data source and calls a common "find" like method.
-/// - Some data source may want to specialize it by inheritance as an
-///   optimization.  For example, in the current schema design of the sqlite3
-///   data source, its (derived) zone class would contain the information of
-///   the "zone ID".
-///
-/// <b>Note:</b> Unlike some other abstract base classes we don't name the
-/// class beginning with "Abstract".  This is because we want to have
-/// commonly used definitions such as \c Result and \c ZoneFinderPtr, and we
-/// want to make them look more intuitive.
+/// \note It's not clear whether we should request that a zone finder form a
+/// "transaction", that is, whether to ensure the finder is not susceptible
+/// to changes made by someone else than the creator of the finder.  If we
+/// don't request that, for example, two different lookup results for the
+/// same name and type can be different if other threads or programs make
+/// updates to the zone between the lookups.  We should revisit this point
+/// as we gain more experiences.
 class ZoneFinder {
 public:
     /// Result codes of the \c find() method.

More information about the bind10-changes mailing list