BIND 10 trac1245, updated. 170a0661dfb17014a62cd2eeaaa99e408bc55a14 [1245] Make CPPPyObjectContainer constructor explicit

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Sep 16 20:01:44 UTC 2011


The branch, trac1245 has been updated
       via  170a0661dfb17014a62cd2eeaaa99e408bc55a14 (commit)
      from  b12f4e55007ee2e8130991f322e782bb31a8a289 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 170a0661dfb17014a62cd2eeaaa99e408bc55a14
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri Sep 16 22:01:23 2011 +0200

    [1245] Make CPPPyObjectContainer constructor explicit

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/python/edns_python.cc       |    2 +-
 src/lib/dns/python/name_python.cc       |    2 +-
 src/lib/dns/python/opcode_python.cc     |    2 +-
 src/lib/dns/python/rcode_python.cc      |    2 +-
 src/lib/dns/python/rrclass_python.cc    |    2 +-
 src/lib/dns/python/rrttl_python.cc      |    2 +-
 src/lib/dns/python/rrtype_python.cc     |    2 +-
 src/lib/dns/python/tsig_rdata_python.cc |    2 +-
 src/lib/dns/python/tsigerror_python.cc  |    2 +-
 src/lib/dns/python/tsigrecord_python.cc |    3 +--
 src/lib/util/python/pycppwrapper_util.h |    2 +-
 11 files changed, 11 insertions(+), 12 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/python/edns_python.cc b/src/lib/dns/python/edns_python.cc
index b1073d8..3893c88 100644
--- a/src/lib/dns/python/edns_python.cc
+++ b/src/lib/dns/python/edns_python.cc
@@ -385,7 +385,7 @@ initModulePart_EDNS(PyObject* mod) {
 
 PyObject*
 createEDNSObject(const EDNS& source) {
-    EDNSContainer container = PyObject_New(s_EDNS, &edns_type);
+    EDNSContainer container(PyObject_New(s_EDNS, &edns_type));
     container.set(new EDNS(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/name_python.cc b/src/lib/dns/python/name_python.cc
index 40c7673..e05f44d 100644
--- a/src/lib/dns/python/name_python.cc
+++ b/src/lib/dns/python/name_python.cc
@@ -722,7 +722,7 @@ initModulePart_Name(PyObject* mod) {
 
 PyObject*
 createNameObject(const Name& source) {
-    NameContainer container = PyObject_New(s_Name, &name_type);
+    NameContainer container(PyObject_New(s_Name, &name_type));
     container.set(new Name(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/opcode_python.cc b/src/lib/dns/python/opcode_python.cc
index 1547457..d9b5545 100644
--- a/src/lib/dns/python/opcode_python.cc
+++ b/src/lib/dns/python/opcode_python.cc
@@ -397,7 +397,7 @@ initModulePart_Opcode(PyObject* mod) {
 
 PyObject*
 createOpcodeObject(const Opcode& source) {
-    OpcodeContainer container = PyObject_New(s_Opcode, &opcode_type);
+    OpcodeContainer container(PyObject_New(s_Opcode, &opcode_type));
     container.set(new Opcode(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/rcode_python.cc b/src/lib/dns/python/rcode_python.cc
index 2e51003..8c4a985 100644
--- a/src/lib/dns/python/rcode_python.cc
+++ b/src/lib/dns/python/rcode_python.cc
@@ -438,7 +438,7 @@ initModulePart_Rcode(PyObject* mod) {
 
 PyObject*
 createRcodeObject(const Rcode& source) {
-    RcodeContainer container = PyObject_New(s_Rcode, &rcode_type);
+    RcodeContainer container(PyObject_New(s_Rcode, &rcode_type));
     container.set(new Rcode(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/rrclass_python.cc b/src/lib/dns/python/rrclass_python.cc
index 87ba32e..d411896 100644
--- a/src/lib/dns/python/rrclass_python.cc
+++ b/src/lib/dns/python/rrclass_python.cc
@@ -364,7 +364,7 @@ initModulePart_RRClass(PyObject* mod) {
 
 PyObject*
 createRRClassObject(const RRClass& source) {
-    RRClassContainer container = PyObject_New(s_RRClass, &rrclass_type);
+    RRClassContainer container(PyObject_New(s_RRClass, &rrclass_type));
     container.set(new RRClass(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/rrttl_python.cc b/src/lib/dns/python/rrttl_python.cc
index bea1d17..1394c0f 100644
--- a/src/lib/dns/python/rrttl_python.cc
+++ b/src/lib/dns/python/rrttl_python.cc
@@ -317,7 +317,7 @@ initModulePart_RRTTL(PyObject* mod) {
 
 PyObject*
 createRRTTLObject(const RRTTL& source) {
-    RRTTLContainer container = PyObject_New(s_RRTTL, &rrttl_type);
+    RRTTLContainer container(PyObject_New(s_RRTTL, &rrttl_type));
     container.set(new RRTTL(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/rrtype_python.cc b/src/lib/dns/python/rrtype_python.cc
index 6b6fcc8..d3479ff 100644
--- a/src/lib/dns/python/rrtype_python.cc
+++ b/src/lib/dns/python/rrtype_python.cc
@@ -458,7 +458,7 @@ initModulePart_RRType(PyObject* mod) {
 
 PyObject*
 createRRTypeObject(const RRType& source) {
-    RRTypeContainer container = PyObject_New(s_RRType, &rrtype_type);
+    RRTypeContainer container(PyObject_New(s_RRType, &rrtype_type));
     container.set(new RRType(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/tsig_rdata_python.cc b/src/lib/dns/python/tsig_rdata_python.cc
index 2a32be8..ee316e0 100644
--- a/src/lib/dns/python/tsig_rdata_python.cc
+++ b/src/lib/dns/python/tsig_rdata_python.cc
@@ -367,7 +367,7 @@ initModulePart_TSIG(PyObject* mod) {
 
 PyObject*
 createTSIGObject(const any::TSIG& source) {
-    TSIGContainer container = PyObject_New(s_TSIG, &tsig_type);
+    TSIGContainer container(PyObject_New(s_TSIG, &tsig_type));
     container.set(new any::TSIG(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/tsigerror_python.cc b/src/lib/dns/python/tsigerror_python.cc
index a3ff402..ba22c05 100644
--- a/src/lib/dns/python/tsigerror_python.cc
+++ b/src/lib/dns/python/tsigerror_python.cc
@@ -361,7 +361,7 @@ initModulePart_TSIGError(PyObject* mod) {
 
 PyObject*
 createTSIGErrorObject(const TSIGError& source) {
-    TSIGErrorContainer container = PyObject_New(s_TSIGError, &tsigerror_type);
+    TSIGErrorContainer container(PyObject_New(s_TSIGError, &tsigerror_type));
     container.set(new TSIGError(source));
     return (container.release());
 }
diff --git a/src/lib/dns/python/tsigrecord_python.cc b/src/lib/dns/python/tsigrecord_python.cc
index f51e5db..c132229 100644
--- a/src/lib/dns/python/tsigrecord_python.cc
+++ b/src/lib/dns/python/tsigrecord_python.cc
@@ -309,8 +309,7 @@ initModulePart_TSIGRecord(PyObject* mod) {
 
 PyObject*
 createTSIGRecordObject(const TSIGRecord& source) {
-    TSIGRecordContainer container = PyObject_New(s_TSIGRecord,
-                                                 &tsigrecord_type);
+    TSIGRecordContainer container(PyObject_New(s_TSIGRecord, &tsigrecord_type));
     container.set(new TSIGRecord(source));
     return (container.release());
 }
diff --git a/src/lib/util/python/pycppwrapper_util.h b/src/lib/util/python/pycppwrapper_util.h
index 3f396e2..462e715 100644
--- a/src/lib/util/python/pycppwrapper_util.h
+++ b/src/lib/util/python/pycppwrapper_util.h
@@ -293,7 +293,7 @@ protected:
 /// \c PyObject_New() to the caller.
 template <typename PYSTRUCT, typename CPPCLASS>
 struct CPPPyObjectContainer : public PyObjectContainer {
-    CPPPyObjectContainer(PYSTRUCT* obj) : PyObjectContainer(obj) {}
+    explicit CPPPyObjectContainer(PYSTRUCT* obj) : PyObjectContainer(obj) {}
 
     // This method associates a C++ object with the corresponding python
     // object enclosed in this class.




More information about the bind10-changes mailing list