BIND 10 trac1579suggest, created. d127560b02816a7ba12869d19ca51a30e695ff35 [1579] suggested addition: a missing test case for an empty wildcard name.

Fri Apr 13 03:24:42 UTC 2012

The branch, trac1579suggest has been created
        at  d127560b02816a7ba12869d19ca51a30e695ff35 (commit)

- Log -----------------------------------------------------------------
commit d127560b02816a7ba12869d19ca51a30e695ff35
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 20:00:45 2012 -0700

    [1579] suggested addition: a missing test case for an empty wildcard name.

commit 793772f302013324ee4964e5b2c3439c0eed2221
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 19:44:02 2012 -0700

    [1579] suggested addition: a missing test case for an empty name.

commit be2b8d67e266598e0fba9e658042986c6833d220
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 18:49:16 2012 -0700

    [1579] suggested updates to unit tests.
    
    - consolidated test scenarios for NSEC and NSEC3 to avoid duplicates
    - also tested the case for findAll()
    - also tested when the zone only has NSEC3PARAM or unsigned

commit 6cd82ad2a63dfc9bcd15dabdf650da242eaf924b
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 16:08:41 2012 -0700

    [1579] suggested doc update.
    
    I also renamed init() to probe() as the latter seemed more appropriate
    in terms of what it does.

commit 493f952e6937adf7045732a2f7e0c4a4313fc0a5
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 15:31:12 2012 -0700

    [1579] cleanup: removed an unused class member variable.

commit 9b6993002b4ba9019551e50613c8a2c6c7ff9fec
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 15:25:46 2012 -0700

    [1579] (suggested) cleanup, mainly moving isNSEC[3] to FindDNSSECContext
    
    these are short, and only used in FindDNSSECContext, so it'd make more sense
    to enclose them there.
    Other cleanups:
    - also made FindDNSSECContext::isNSEC/isNSEC3 private as they now don't need
      to be called outside the class
    - removed isInited(); simpy doesn't see the need for it as a separate method
    - simplified the code logic of getResultFlag()

commit fb2317550507bb357cba2eee89c3a469f1a89803
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 14:55:42 2012 -0700

    [1579] cleanup: FINAL_TYPES_NO_NSEC & findNSECCover are now unused and removed.
    
    the latter has been merged to getDNSSECRRset().  doxygen comments were
    also merged.

commit 52e971851f0c7ee8f45c511d810497e3c038dc71
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 14:46:01 2012 -0700

    [1579] suggested change: made findNoNameResult completely DNSSEC-agnostic.
    
    same adjustment as the previous comment was made for tests.
    also fixed a small bug in getDNSSECRRset(): I should have reversed the
    logic for need_nscheck.

commit 07274f662a772c856f0bf80213b246e689582409
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 14:25:41 2012 -0700

    [1579] suggested change: made findNoNameResult a bit more DNSSEC-agnostic.
    
    to make a related test pass, incorporated the NotImplemented exception
    handling from findNSECCover to getDNSSECRRset.
    note: in this commit I reversed the behavior when we encounter the situation
    where NSEC is expected but cannot be found; it now returns a NULL pointer,
    although the NSEC_SIGNED flag can be still set.
    
    It's a quite broken case of zone config so it's probably up to the
    implementation, and in that sense throwing an exception is not necessary
    wrong.  But we may have such a situation in a valid scenario if and when we
    support incremental zone signing.  Also, this behavior is consistent with
    BIND 9.
    
    The emptyNonterminalNSEC test case was adjusted accordingly.

commit c3bc4e02519d15e27b8e32291bda1a59ed08f42b
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 13:55:14 2012 -0700

    [1579] suggest change: made findWildcardMatch DNSSEC-agnostic.
    
    to do this, I extended getDNSSECRRset(name) further: it now takes 'covering'
    parameter, depending on whether the requested NSEC is for the exact name
    or the covering ("previous") name.  In the latter case it does the same
    thing as findNSECCover() (which will be merged to getDNSSECRRset later).

commit b77375be27718eea1619f4e4fdb4899a29eea18e
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 13:23:20 2012 -0700

    [1579] suggested change: made findOnNameResult DNSSEC-agnostic about flags.
    
    now FindDNSSECContext has sufficient information to choose the correct flag,
    findOnNameResult() can simply call its getResultFlags().
    as an additional bonus, we can constify 'flags'.

commit 05793b5a18793908b17190008382a27e133e5979
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 13:09:41 2012 -0700

    [1579] suggested change: made findOnNameResult more DNSSEC agnostic
    
    - renamed getNSECRRset to getDNSSECRRset to clarify it's for generic DNSSEC
      purpose, even though it's essentially NSEC specific.
    - moved the 'isNSEC' check to the now-renamed getDNSSECRRset, thereby removing
      the need for checking that within findOnNameResult.

commit 186bacfc7ba324647f6689fd627c8d9d2d724c0c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 11:50:05 2012 -0700

    [1579] suggested change: pass a reference of ZoneFinder to DNSSECContext.
    
    instead of a pointer.
    IMO, finderp_ should better be a reference than a pointer if we'd
    worry about the case where it's NULL later on, like getNSECRRset
    does (which shouldn't never happen in our usage).
    the NULL pointer check was therefore removed with this change.

commit 058af3dc4b9f1e03d46c549f3ea848fb1a5c7960
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Apr 12 11:40:09 2012 -0700

    [1579] suggested changes: made FindDNSSECContext more focused.
    
    removed origin_ or complete flags_ from the class members.  non DNSSEC-specific
    processing was recovered from the original version.
    also made FindDNSSECContext private inside ZoneFinder; it doesn't have to
    be publicly usable.
    also made indentation policy more consistent for the class.

-----------------------------------------------------------------------