BIND 10 trac1781, updated. 211934fe44eb6ea5a74857d4312e10b6cd6a3c55 [1781] doc: explicitly noted DataSourceError can be thrown from NSEC3 methods.
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Apr 16 21:43:00 UTC 2012
The branch, trac1781 has been updated
via 211934fe44eb6ea5a74857d4312e10b6cd6a3c55 (commit)
via 136e63b8234f46a46c4278e4ccfe9712a76ebfc9 (commit)
from d78d0dbcec53a339b7789b181954768d181c2a1b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 211934fe44eb6ea5a74857d4312e10b6cd6a3c55
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Mon Apr 16 14:16:18 2012 -0700
[1781] doc: explicitly noted DataSourceError can be thrown from NSEC3 methods.
(as suggested in review)
commit 136e63b8234f46a46c4278e4ccfe9712a76ebfc9
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Mon Apr 16 14:02:50 2012 -0700
[1781] small editorial/style fixes: updated comment and use unnamed namespace.
the previous "TODO" comment was a leftover when I moved it from the datasrc
test. also moved the callback function to the unnamed namespace as it
doesn't have to be referrable from others.
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/database.h | 6 +++++-
src/lib/testutils/dnsmessage_test.cc | 5 ++---
2 files changed, 7 insertions(+), 4 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/database.h b/src/lib/datasrc/database.h
index b77ab3e..ca05d0a 100644
--- a/src/lib/datasrc/database.h
+++ b/src/lib/datasrc/database.h
@@ -482,9 +482,11 @@ public:
/// unexpected type of RRs (and the result of subsequent lookups) is
/// undefined.
///
- /// Other general notes for \c addRecordToZone() also applies to this
+ /// Other general notes for \c addRecordToZone() also apply to this
/// method.
///
+ /// \exception DataSourceError Invalid call without starting a transaction,
+ /// or other internal database error.
/// \exception isc::NotImplemented in case the database does not support
/// NSEC3
///
@@ -545,6 +547,8 @@ public:
/// This is the same as \c ADD_NSEC3_HASH column for
/// \c addRecordToNSEC3Zone().
///
+ /// \exception DataSourceError Invalid call without starting a transaction,
+ /// or other internal database error.
/// \exception isc::NotImplemented in case the database does not support
/// NSEC3
///
diff --git a/src/lib/testutils/dnsmessage_test.cc b/src/lib/testutils/dnsmessage_test.cc
index a2a64d6..244f433 100644
--- a/src/lib/testutils/dnsmessage_test.cc
+++ b/src/lib/testutils/dnsmessage_test.cc
@@ -86,10 +86,8 @@ matchRdata(const char*, const char*,
}
return (::testing::AssertionSuccess());
}
-}
-// TODO: maybe we should share this stuff
-// A helper callback of masterLoad() used in InMemoryZoneFinderTest.
+// A helper callback of masterLoad() used by textToRRset() below.
void
setRRset(RRsetPtr rrset, RRsetPtr* rrsetp) {
if (*rrsetp) {
@@ -98,6 +96,7 @@ setRRset(RRsetPtr rrset, RRsetPtr* rrsetp) {
}
*rrsetp = rrset;
}
+}
RRsetPtr
textToRRset(const string& text_rrset, const RRClass& rrclass) {
More information about the bind10-changes
mailing list