BIND 10 trac2100, created. 0a15919f5570c67cc6cfee64fbbb83732098cd51 [2100] (not directly related) cleanup: always destroy old data in setData().
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Aug 9 01:00:45 UTC 2012
The branch, trac2100 has been created
at 0a15919f5570c67cc6cfee64fbbb83732098cd51 (commit)
- Log -----------------------------------------------------------------
commit 0a15919f5570c67cc6cfee64fbbb83732098cd51
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:56:16 2012 -0700
[2100] (not directly related) cleanup: always destroy old data in setData().
actually the previous implementation seems buggy; it returns the given pionter,
not the old data. Worse, this code path isn't tested. It's a typical example
of YAGNI; if we don't see the need for it, don't do it; if you cannot regist
the temptation of making it smarter, at least you should write tests.
At least ZoneTable doesn't need it, so I chose to clean it up. If and when
we find it necessary, we should implementation from the scratch, and
test-driven.
commit 920a2f5a59f8c78e407e4a0cd49e73f466adacd8
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:52:26 2012 -0700
[2100] use offset pointer for domaintree data.
not absolutely necessary for this branch, but that's the intent anyway.
commit aef961dacd7f9ed32410426fa5cce015cb35c224
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:46:11 2012 -0700
[2100] use offset pointer for the underlying tree
commit 86f3e7053f03a475f5a56e0017d2459c95461f00
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:38:25 2012 -0700
[2100] cleanup: removed removeZone().
right now it doesn't work, and when we need to implement it, the internal
will need to be substantially updated anyway, so it doesn't make much sense
to keep the nonworkable version.
commit ed62080de7677102f09acc0eca4e6026178c9d25
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:37:23 2012 -0700
[2100] documentation update
commit 450fef21a63c432b7cd439228ac98a839d335a87
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 17:15:50 2012 -0700
[2100] updated the return type of findZone().
It now simply returns ZoneData as the data associated with the code;
the corresponding client implementation will create a zone finder from it.
also updated some doc.
commit 2e9fc841b3315b7c52166a49ce8299de2d251699
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 16:48:36 2012 -0700
[2100] return the created zone data from addZone.
commit 3e433eb3ea7937dec94549d04053b808f8f3869e
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 16:26:28 2012 -0700
[2100] improved exception safety.
commit c2f339c9a062542e1f2918de73f48e14d8b66645
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 15:36:45 2012 -0700
[2100] revised addZone() iface: now it only takes name, creates data in it.
also completed the zone table deleter.
commit 311f8b58911f6d4cb2760d224c67e16c85675684
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Aug 8 14:32:32 2012 -0700
[2100] ensure exception safety in ZoneTable::create using a holder class.
instead of using the ugly try-(catch-all)catch.
commit a98c9ab9a636d075e10f826620fa1aab2ded892c
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Aug 7 23:59:44 2012 -0700
[2100] simplify: move definitions to the main class instead of pimpl.
this is mostly private class and is not expected to be referenced outside
of this psuedo module ("memory"), so it's raltively safer.
also, the ZoneTable structure will be embedable in a shared memory space,
so introducing the another pointer indirection will make it unnecessarily
complicated.
still don't pass tests.
commit 5cd828127e95f334d4983bb4175de01ce33cabb2
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Aug 7 23:45:21 2012 -0700
[2100] make the new implementation compile.
added a mostly-empty implementation of ZoneData.
at this point it's nothing more than "buildable" code. tests still don't pass.
commit 57de7551b2cc0206f8d1a3ffae9d60b4097ecde1
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Aug 7 18:06:40 2012 -0700
[2100] copy the old zone table implementation and tests under "memory" dir.
right now it's a naive copy. the test wouldn't even compile.
-----------------------------------------------------------------------
More information about the bind10-changes
mailing list