BIND 10 trac2164, updated. 98ce97d9b83b6bf98f44626713a268c2db4de6f9 [2164] Add another testcase when RRSIGs are removed

BIND 10 source code commits bind10-changes at lists.isc.org
Sun Aug 12 19:40:27 UTC 2012


The branch, trac2164 has been updated
       via  98ce97d9b83b6bf98f44626713a268c2db4de6f9 (commit)
       via  3ed457da1be08a3ed59186cd65f040d5d8fc5aa2 (commit)
      from  ceec0dc9bbe97153a0b39f2e387fbc53be81a2e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 98ce97d9b83b6bf98f44626713a268c2db4de6f9
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Aug 13 01:09:46 2012 +0530

    [2164] Add another testcase when RRSIGs are removed

commit 3ed457da1be08a3ed59186cd65f040d5d8fc5aa2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Aug 13 01:08:14 2012 +0530

    [2164] Update syntax of rrsig_ test as it is a shared_ptr

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/rrset.cc                |    2 +-
 src/lib/dns/tests/rrset_unittest.cc |    4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/rrset.cc b/src/lib/dns/rrset.cc
index d713278..969ae97 100644
--- a/src/lib/dns/rrset.cc
+++ b/src/lib/dns/rrset.cc
@@ -251,7 +251,7 @@ RRset::~RRset() {}
 
 unsigned int
 RRset::getSIGRdataCount() const {
-    if (rrsig_ != NULL) {
+    if (rrsig_) {
         return (rrsig_->getRdataCount());
     } else {
         return (0);
diff --git a/src/lib/dns/tests/rrset_unittest.cc b/src/lib/dns/tests/rrset_unittest.cc
index 37dd8c2..3b16a4a 100644
--- a/src/lib/dns/tests/rrset_unittest.cc
+++ b/src/lib/dns/tests/rrset_unittest.cc
@@ -354,7 +354,9 @@ TEST_F(RRsetRRSIGTest, getSIGRdataCount) {
                                          "20000101000000 20000201000000 "
                                          "12345 example.com. FAKEFAKEFAKE"));
     rrset_a->addRRsig(rrset_rrsig);
-
     EXPECT_EQ(2, rrset_a->getSIGRdataCount());
+
+    rrset_a->removeRRsig();
+    EXPECT_EQ(0, rrset_a->getSIGRdataCount());
 }
 }



More information about the bind10-changes mailing list