BIND 10 trac2138, updated. 69a1786aaeec95803c00640b7f52481b1b6bee5b [2138] revised exceptionGuarantee test so it will actually modify state once.
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Aug 21 18:37:25 UTC 2012
The branch, trac2138 has been updated
via 69a1786aaeec95803c00640b7f52481b1b6bee5b (commit)
via 9463f3e4ebe36a200ef4107af976dbb2ea7a2b67 (commit)
from caa70d6b850f75119b9b8f7c71caf8e56bdc47a6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 69a1786aaeec95803c00640b7f52481b1b6bee5b
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Aug 21 11:36:44 2012 -0700
[2138] revised exceptionGuarantee test so it will actually modify state once.
commit 9463f3e4ebe36a200ef4107af976dbb2ea7a2b67
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Aug 21 10:52:01 2012 -0700
[2138] made the comment for AuthCommandTest::getStats more sense.
-----------------------------------------------------------------------
Summary of changes:
src/bin/auth/tests/command_unittest.cc | 2 +-
src/bin/auth/tests/config_unittest.cc | 15 +++++++++------
2 files changed, 10 insertions(+), 7 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/auth/tests/command_unittest.cc b/src/bin/auth/tests/command_unittest.cc
index 3daa1cb..a22725e 100644
--- a/src/bin/auth/tests/command_unittest.cc
+++ b/src/bin/auth/tests/command_unittest.cc
@@ -418,7 +418,7 @@ TEST_F(AuthCommandTest, loadZoneInvalidParams) {
TEST_F(AuthCommandTest, getStats) {
result_ = execAuthServerCommand(server_, "getstats", ConstElementPtr());
parseAnswer(rcode_, result_);
- // Just check some message has been received. Detailed tests specific to
+ // Just check the command execution succeeded. Detailed tests specific to
// statistics are done in its own tests.
EXPECT_EQ(0, rcode_);
}
diff --git a/src/bin/auth/tests/config_unittest.cc b/src/bin/auth/tests/config_unittest.cc
index a44f04f..9a0fb59 100644
--- a/src/bin/auth/tests/config_unittest.cc
+++ b/src/bin/auth/tests/config_unittest.cc
@@ -81,22 +81,25 @@ TEST_F(AuthConfigTest, versionConfig) {
TEST_F(AuthConfigTest, exceptionGuarantee) {
using namespace isc::server_common::portconfig;
- AddressList a, b, c;
+ AddressList a;
a.push_back(AddressPair("127.0.0.1", 53210));
server.setListenAddresses(a);
- b = server.getListenAddresses();
+ const AddressList b = server.getListenAddresses();
EXPECT_EQ(a.size(), b.size());
EXPECT_EQ(a.at(0).first, b.at(0).first);
EXPECT_EQ(a.at(0).second, b.at(0).second);
- // This configuration contains an invalid item, which will trigger
- // an exception.
+ // The test socket request will reject the second address (192.0.2.2)
+ // with an exception
EXPECT_THROW(configureAuthServer(
server,
Element::fromJSON(
- "{ \"no_such_config_var\": 1}")),
+ "{ \"listen_on\": ["
+ "{\"address\": \"::1\", \"port\": 53210},"
+ "{\"address\": \"192.0.2.2\", \"port\": 53210}"
+ "]}")),
AuthConfigError);
// The server state shouldn't change
- c = server.getListenAddresses();
+ const AddressList c = server.getListenAddresses();
EXPECT_EQ(a.size(), c.size());
EXPECT_EQ(a.at(0).first, c.at(0).first);
EXPECT_EQ(a.at(0).second, c.at(0).second);
More information about the bind10-changes
mailing list