BIND 10 trac2165_2, updated. 94d0fd242d1b56ac9afe56e8f1240084946556c5 [2165] updater.delete_rrset no longer raises (as there are no attached RRSIGs now)

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Aug 23 03:52:03 UTC 2012


The branch, trac2165_2 has been updated
       via  94d0fd242d1b56ac9afe56e8f1240084946556c5 (commit)
      from  1fbbeb35aae24cab6e48169517e6aafadb9dc97d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 94d0fd242d1b56ac9afe56e8f1240084946556c5
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Aug 23 09:19:37 2012 +0530

    [2165] updater.delete_rrset no longer raises (as there are no attached RRSIGs now)

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/datasrc/tests/datasrc_test.py |   16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/datasrc/tests/datasrc_test.py b/src/lib/python/isc/datasrc/tests/datasrc_test.py
index 74f822f..b8e6fb2 100644
--- a/src/lib/python/isc/datasrc/tests/datasrc_test.py
+++ b/src/lib/python/isc/datasrc/tests/datasrc_test.py
@@ -482,15 +482,9 @@ class DataSrcUpdater(unittest.TestCase):
                          rrset.to_text())
 
         rrset_to_delete = rrset;
-
-        # can't delete rrset with associated sig. Abuse that to force an
-        # exception first, then remove the sig, then delete the record
-        updater = dsc.get_updater(isc.dns.Name("example.com"), True)
-        self.assertRaises(isc.datasrc.Error, updater.delete_rrset,
-                          rrset_to_delete)
-
         rrset_to_delete.remove_rrsig()
 
+        updater = dsc.get_updater(isc.dns.Name("example.com"), True)
         updater.delete_rrset(rrset_to_delete)
 
         # The record should be gone in the updater, but not in the original
@@ -582,15 +576,9 @@ class DataSrcUpdater(unittest.TestCase):
                          rrset.to_text())
 
         rrset_to_delete = rrset;
-
-        # can't delete rrset with associated sig. Abuse that to force an
-        # exception first, then remove the sig, then delete the record
-        updater = dsc.get_updater(isc.dns.Name("example.com"), True)
-        self.assertRaises(isc.datasrc.Error, updater.delete_rrset,
-                          rrset_to_delete)
-
         rrset_to_delete.remove_rrsig()
 
+        updater = dsc.get_updater(isc.dns.Name("example.com"), True)
         updater.delete_rrset(rrset_to_delete)
 
         # The record should be gone in the updater, but not in the original



More information about the bind10-changes mailing list