BIND 10 trac2096, updated. 5b27cee6f2b2ea3199700f2358ab38655c60e5eb [2096] Minor improvements

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Aug 24 10:23:44 UTC 2012


The branch, trac2096 has been updated
       via  5b27cee6f2b2ea3199700f2358ab38655c60e5eb (commit)
      from  b97f714d59f1990b62a01e5ca0c5f1c95834ed7c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b27cee6f2b2ea3199700f2358ab38655c60e5eb
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Fri Aug 24 12:15:52 2012 +0200

    [2096] Minor improvements
    
    * Check for impossible return value and throw in that case.
    * Call nextInternal directly, to avoid some indirection. This might
      cause a small performance benefit.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory/rdata_serialization.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/rdata_serialization.h b/src/lib/datasrc/memory/rdata_serialization.h
index 4f65971..085a6e3 100644
--- a/src/lib/datasrc/memory/rdata_serialization.h
+++ b/src/lib/datasrc/memory/rdata_serialization.h
@@ -322,7 +322,7 @@ public:
     /// therefore if you already called next() yourself, it does not start
     /// at the beginning).
     void iterate() {
-        while (next() != RRSET_BOUNDARY) {}
+        while (nextInternal(name_action_, data_action_) != RRSET_BOUNDARY) {}
     }
 
     /// \brief Call next() until the end of current rdata.
@@ -334,7 +334,7 @@ public:
     /// \return If there was Rdata to iterate through.
     bool iterateRdata() {
         while (true) {
-            switch (next()) {
+            switch (nextInternal(name_action_, data_action_)) {
                 case NO_BOUNDARY: break;
                 case RDATA_BOUNDARY: return (true);
                 case RRSET_BOUNDARY: return (false);
@@ -365,7 +365,9 @@ public:
     bool iterateSingleSig() {
         while (true) {
             switch (nextSig()) {
-                case NO_BOUNDARY: break;
+                case NO_BOUNDARY:
+                    isc_throw(isc::Unexpected, "NO_BOUNDARY inside an RRSig. "
+                              "Data corruption? Bug inside RdataReader?");
                 case RDATA_BOUNDARY: return (true);
                 case RRSET_BOUNDARY: return (false);
             }



More information about the bind10-changes mailing list