BIND 10 trac2491, updated. c831a1e66e88bceb6a317dd8de0796b315681f4f [2491] Corrected the type of reference data.

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Dec 4 22:07:38 UTC 2012


The branch, trac2491 has been updated
       via  c831a1e66e88bceb6a317dd8de0796b315681f4f (commit)
      from  b1d0e42774ef51b404be44ee53cb930a630a63bb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c831a1e66e88bceb6a317dd8de0796b315681f4f
Author: Marcin Siodelski <marcin at isc.org>
Date:   Tue Dec 4 23:07:30 2012 +0100

    [2491] Corrected the type of reference data.
    
    With this fix we avoid narrowing conversion from signed to unsigned value.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/tests/option_data_types_unittest.cc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/tests/option_data_types_unittest.cc b/src/lib/dhcp/tests/option_data_types_unittest.cc
index 0e3f7ec..a185cdf 100644
--- a/src/lib/dhcp/tests/option_data_types_unittest.cc
+++ b/src/lib/dhcp/tests/option_data_types_unittest.cc
@@ -121,7 +121,7 @@ TEST_F(OptionDataTypesTest, writeAddress) {
     // Encode an IPv6 address 2001:db8:1::1 in wire format.
     // This will be used as reference data to validate if
     // an IPv6 address is stored in a buffer properly.
-    const char data[] = {
+    const uint8_t data[] = {
         0x20, 0x01, 0x0d, 0xb8, 0x0, 0x1, 0x0, 0x0,
         0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1
     };
@@ -316,7 +316,7 @@ TEST_F(OptionDataTypesTest, readInt) {
 // types are correctly written to a buffer.
 TEST_F(OptionDataTypesTest, writeInt) {
     // Prepare the reference buffer.
-    const char data[] = {
+    const uint8_t data[] = {
         0x7F, // 127
         0x03, 0xFF, // 1023
         0x00, 0x00, 0x10, 0x00, // 4096



More information about the bind10-changes mailing list