BIND 10 trac2404, updated. fca31329405278e34049e2e19982a82bc6fdf4f2 [2404] Minor changes as a result of review

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Dec 7 11:36:37 UTC 2012


The branch, trac2404 has been updated
       via  fca31329405278e34049e2e19982a82bc6fdf4f2 (commit)
      from  8f6903dc068a22c2966e9c28c90c14b6d83543cc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fca31329405278e34049e2e19982a82bc6fdf4f2
Author: Stephen Morris <stephen at isc.org>
Date:   Fri Dec 7 11:18:47 2012 +0000

    [2404] Minor changes as a result of review

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/duid.h               |    5 +++++
 src/lib/dhcpsrv/mysql_lease_mgr.h |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/duid.h b/src/lib/dhcp/duid.h
index fe642f4..1b75f73 100644
--- a/src/lib/dhcp/duid.h
+++ b/src/lib/dhcp/duid.h
@@ -91,6 +91,11 @@ public:
     /// @brief Maximum size of a client ID
     ///
     /// This is the same as the maximum size of the underlying DUID.
+    ///
+    /// @note RFC 2131 does not specify an upper length of a client ID, the
+    ///       value chosen here just being that of the underlying DUID.  For
+    ///       some backend database, there may be a possible (minor)
+    ///       performance enhancement if this were smaller.
     static const size_t MAX_CLIENT_ID_LEN = DUID::MAX_DUID_LEN;
 
     /// @brief Constructor based on vector<uint8_t>
diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.h b/src/lib/dhcpsrv/mysql_lease_mgr.h
index be86c3a..8a97fc0 100644
--- a/src/lib/dhcpsrv/mysql_lease_mgr.h
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.h
@@ -110,7 +110,7 @@ public:
     /// @brief Returns an IPv4 lease for specified IPv4 address
     ///
     /// This method return a lease that is associated with a given address.
-    /// For other query types (by hardware addr, by DUID) there can be
+    /// For other query types (by hardware addr, by Client ID) there can be
     /// several leases in different subnets (e.g. for mobile clients that
     /// got address in different subnets). However, for a single address
     /// there can be only one lease, so this method returns a pointer to



More information about the bind10-changes mailing list