BIND 10 trac2377, updated. 03911f1000649e0db11d1bbd956b2df5732a5a44 [2377] Use rrsetCheck() for comparing RRsets
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Dec 7 14:20:40 UTC 2012
The branch, trac2377 has been updated
discards 2580bf5a49c4d26ccb3077226ef4897138f044c3 (commit)
via 03911f1000649e0db11d1bbd956b2df5732a5a44 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (2580bf5a49c4d26ccb3077226ef4897138f044c3)
\
N -- N -- N (03911f1000649e0db11d1bbd956b2df5732a5a44)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 03911f1000649e0db11d1bbd956b2df5732a5a44
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date: Fri Dec 7 15:02:18 2012 +0100
[2377] Use rrsetCheck() for comparing RRsets
Comparing their toText() might be unreliable. In theory, the toText()
result could be slightly different even for equal RRsets (if their
background implementation is different) and the test fail.
Include a hack for the rrsetCheck interface being incompatible.
-----------------------------------------------------------------------
Summary of changes:
.../datasrc/tests/master_loader_callbacks_test.cc | 1 -
1 file changed, 1 deletion(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/tests/master_loader_callbacks_test.cc b/src/lib/datasrc/tests/master_loader_callbacks_test.cc
index 48469e3..19ec4d2 100644
--- a/src/lib/datasrc/tests/master_loader_callbacks_test.cc
+++ b/src/lib/datasrc/tests/master_loader_callbacks_test.cc
@@ -58,7 +58,6 @@ public:
}
isc::testutils::rrsetCheck(expected_rrsets_.front(), copy);
- EXPECT_EQ(expected_rrsets_.front().get()->toText(), rrset.toText());
// And remove this RRset, as it has been used.
expected_rrsets_.pop_front();
}
More information about the bind10-changes
mailing list