BIND 10 trac2445, updated. 0a9dafbece0545af535494a7e5745a14c87ed9f5 [2445] make initializaation for BufferAppenderTest more exception safe.
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Dec 10 17:31:02 UTC 2012
The branch, trac2445 has been updated
via 0a9dafbece0545af535494a7e5745a14c87ed9f5 (commit)
from 8065343bc1c50353260809254e1994642f2b1763 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0a9dafbece0545af535494a7e5745a14c87ed9f5
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Mon Dec 10 09:29:36 2012 -0800
[2445] make initializaation for BufferAppenderTest more exception safe.
by encapsulating the appender in SharedAppenderPtr immediately after the
creation, we can make sure buffer_appender1 won't leak even if the
creation of the second appender fails.
-----------------------------------------------------------------------
Summary of changes:
src/lib/log/tests/buffer_appender_unittest.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/log/tests/buffer_appender_unittest.cc b/src/lib/log/tests/buffer_appender_unittest.cc
index 78367ca..781fcbe 100644
--- a/src/lib/log/tests/buffer_appender_unittest.cc
+++ b/src/lib/log/tests/buffer_appender_unittest.cc
@@ -45,8 +45,8 @@ public:
class BufferAppenderTest : public ::testing::Test {
protected:
BufferAppenderTest() : buffer_appender1(new TestBufferAppender()),
- buffer_appender2(new TestBufferAppender()),
appender1(buffer_appender1),
+ buffer_appender2(new TestBufferAppender()),
appender2(buffer_appender2),
logger(log4cplus::Logger::getInstance("buffer"))
{
@@ -69,8 +69,8 @@ protected:
}
TestBufferAppender* buffer_appender1;
- TestBufferAppender* buffer_appender2;
log4cplus::SharedAppenderPtr appender1;
+ TestBufferAppender* buffer_appender2;
log4cplus::SharedAppenderPtr appender2;
log4cplus::Logger logger;
};
More information about the bind10-changes
mailing list