BIND 10 trac2565, updated. 025db8d7a207b39174362981868742f1b80bdf69 [2565] Update comment about exception overhead
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Dec 28 05:32:21 UTC 2012
The branch, trac2565 has been updated
via 025db8d7a207b39174362981868742f1b80bdf69 (commit)
via 00845ee8d7366b80e23e349b7cf8cd9d52551785 (commit)
from 080d47deb3088adddd96434acfd1c82bd14779c9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 025db8d7a207b39174362981868742f1b80bdf69
Author: Mukund Sivaraman <muks at isc.org>
Date: Fri Dec 28 11:02:00 2012 +0530
[2565] Update comment about exception overhead
commit 00845ee8d7366b80e23e349b7cf8cd9d52551785
Author: Mukund Sivaraman <muks at isc.org>
Date: Fri Dec 28 10:45:54 2012 +0530
[2565] Specify parameter kind in exception messages
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/rrclass.cc | 2 +-
src/lib/dns/rrparamregistry.h | 10 ++++------
src/lib/dns/rrtype.cc | 2 +-
3 files changed, 6 insertions(+), 8 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/rrclass.cc b/src/lib/dns/rrclass.cc
index 4874a9b..76a2e73 100644
--- a/src/lib/dns/rrclass.cc
+++ b/src/lib/dns/rrclass.cc
@@ -33,7 +33,7 @@ namespace dns {
RRClass::RRClass(const std::string& class_str) {
if (!RRParamRegistry::getRegistry().textToClassCode(class_str, classcode_)) {
isc_throw(InvalidRRClass,
- "Unrecognized RR parameter string: " + class_str);
+ "Unrecognized RR class string: " + class_str);
}
}
diff --git a/src/lib/dns/rrparamregistry.h b/src/lib/dns/rrparamregistry.h
index dfa4463..bf86436 100644
--- a/src/lib/dns/rrparamregistry.h
+++ b/src/lib/dns/rrparamregistry.h
@@ -392,9 +392,8 @@ public:
/// corresponding number as the type code in \c type_code;
/// otherwise, it returns false and \c type_code is untouched.
///
- /// We return \c false and avoid simply throwing an exception in the
- /// case of an error so that the code is performant in some
- /// situations.
+ /// It returns \c false and avoids throwing an exception in the case
+ /// of an error to avoid the exception overhead in some situations.
///
/// \param type_string The textual representation of the RR type.
/// \param type_code Returns the RR type code in this argument.
@@ -431,9 +430,8 @@ public:
/// \c class_code; otherwise, it returns false and \c class_code is
/// untouched.
///
- /// We return \c false and avoid simply throwing an exception in the
- /// case of an error so that the code is performant in some
- /// situations.
+ /// It returns \c false and avoids throwing an exception in the case
+ /// of an error to avoid the exception overhead in some situations.
///
/// \param class_string The textual representation of the RR class.
/// \param class_code Returns the RR class code in this argument.
diff --git a/src/lib/dns/rrtype.cc b/src/lib/dns/rrtype.cc
index fd981f2..84892bf 100644
--- a/src/lib/dns/rrtype.cc
+++ b/src/lib/dns/rrtype.cc
@@ -34,7 +34,7 @@ namespace dns {
RRType::RRType(const std::string& type_str) {
if (!RRParamRegistry::getRegistry().textToTypeCode(type_str, typecode_)) {
isc_throw(InvalidRRType,
- "Unrecognized RR parameter string: " + type_str);
+ "Unrecognized RR type string: " + type_str);
}
}
More information about the bind10-changes
mailing list