BIND 10 trac1596, updated. 9e363eaa09c4ab1945ba91a117cca7ea892ea78a [1596] Some comments
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Feb 13 11:17:52 UTC 2012
The branch, trac1596 has been updated
via 9e363eaa09c4ab1945ba91a117cca7ea892ea78a (commit)
from 30219fe1326f00e468fd05bcf80e3ac47b5f4e3c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9e363eaa09c4ab1945ba91a117cca7ea892ea78a
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date: Mon Feb 13 12:17:35 2012 +0100
[1596] Some comments
-----------------------------------------------------------------------
Summary of changes:
src/bin/bind10/bind10_src.py.in | 10 +++++++---
src/bin/resolver/main.cc | 8 ++------
src/lib/python/isc/bind10/component.py | 6 +++---
3 files changed, 12 insertions(+), 12 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/bind10/bind10_src.py.in b/src/bin/bind10/bind10_src.py.in
index 3037a2b..2f7456f 100755
--- a/src/bin/bind10/bind10_src.py.in
+++ b/src/bin/bind10/bind10_src.py.in
@@ -193,9 +193,13 @@ class BoB:
self.nocache = nocache
self.component_config = {}
# Some time in future, it may happen that a single component has
- # multple processes. If so happens, name "components" may be
- # inapropriate. But as the code isn't probably completely ready
- # for it, we leave it at components for now.
+ # multple processes (like a pipeline-like component). If so happens,
+ # name "components" may be inapropriate. But as the code isn't probably
+ # completely ready for it, we leave it at components for now. We also
+ # want to support multiple instances of a single component. If it turns
+ # out that we'll have a single component with multiple same processes
+ # or if we start multiple components with the same configuration (we do
+ # this now, but it might change) is an open question.
self.components = {}
# Simply list of components that died and need to wait for a
# restart. Components manage their own restart schedule now
diff --git a/src/bin/resolver/main.cc b/src/bin/resolver/main.cc
index 8d005ac..1be8b2c 100644
--- a/src/bin/resolver/main.cc
+++ b/src/bin/resolver/main.cc
@@ -94,12 +94,8 @@ my_command_handler(const string& command, ConstElementPtr args) {
const int pid(args->get("pid")->intValue());
const pid_t my_pid(getpid());
if (my_pid != pid) {
- // It is not for us
- //
- // Note that this is completely expected situation, if
- // there are multiple instances of the server running and
- // another instance is being shut down, we get the message
- // too, due to the multicast nature of our message bus.
+ // It is not for us (this is expected, see auth/command.cc
+ // and the ShutdownCommand there).
return answer;
}
}
diff --git a/src/lib/python/isc/bind10/component.py b/src/lib/python/isc/bind10/component.py
index a3ae0b8..091bfee 100644
--- a/src/lib/python/isc/bind10/component.py
+++ b/src/lib/python/isc/bind10/component.py
@@ -22,9 +22,9 @@ Dependencies between them are not yet handled. It might turn out they are
needed, in that case they will be added sometime in future.
This framework allows for a single process to be started multiple times (by
-specifying multiple components with the same configuration). However, the rest
-of the system might not handle such situation well, so until it is made so,
-it would be better to start each process at most once.
+specifying multiple components with the same configuration). We might want
+to add a more convenient support (like providing a count argument to the
+configuration). This is yet to be designed.
"""
import isc.log
More information about the bind10-changes
mailing list