BIND 10 trac1649, updated. ee4edb317a513bcc1230a4edb8edcd91b8a796ca [1649] address review comments

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Feb 15 13:53:23 UTC 2012


The branch, trac1649 has been updated
       via  ee4edb317a513bcc1230a4edb8edcd91b8a796ca (commit)
      from  bbd3fd0f48b0f20174ad7fb75ff1ba75c4bd2731 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ee4edb317a513bcc1230a4edb8edcd91b8a796ca
Author: Jelte Jansen <jelte at isc.org>
Date:   Wed Feb 15 14:53:13 2012 +0100

    [1649] address review comments

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/config/config_data.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/config/config_data.py b/src/lib/python/isc/config/config_data.py
index 62a4556..f8da086 100644
--- a/src/lib/python/isc/config/config_data.py
+++ b/src/lib/python/isc/config/config_data.py
@@ -150,13 +150,13 @@ def _find_spec_part_single(cur_spec, id_part):
     # list or a map, which is internally represented by a dict with
     # an element 'map_item_spec', a dict with an element 'list_item_spec',
     # or a list (when it is the 'main' config_data element of a module).
-    if type(cur_spec) == dict and spec_part_is_map(cur_spec):
+    if spec_part_is_map(cur_spec):
         for cur_spec_item in cur_spec['map_item_spec']:
             if cur_spec_item['item_name'] == id:
                 return cur_spec_item
         # not found
         raise isc.cc.data.DataNotFoundError(id + " not found")
-    elif type(cur_spec) == dict and spec_part_is_list(cur_spec):
+    elif spec_part_is_list(cur_spec):
         if cur_spec['item_name'] == id:
             return cur_spec['list_item_spec']
         # not found
@@ -203,7 +203,7 @@ def find_spec_part(element, identifier, strict_identifier = True):
         if strict_identifier and spec_part_is_list(cur_el) and\
            not isc.cc.data.identifier_has_list_index(id_part):
             raise isc.cc.data.DataNotFoundError(id_part +
-                                                " is a list and needs index")
+                                                " is a list and needs an index")
         cur_el = _get_map_or_list(cur_el)
 
     cur_el = _find_spec_part_single(cur_el, id_parts[-1])




More information about the bind10-changes mailing list