BIND 10 trac1573, updated. d4436ec72742cfa447c7a46b377b134a8e82185d [1573] bit of cleanup
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Jan 26 15:15:16 UTC 2012
The branch, trac1573 has been updated
via d4436ec72742cfa447c7a46b377b134a8e82185d (commit)
from c9739b8fcdb24832f58bcc0c550eb1f63917539f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d4436ec72742cfa447c7a46b377b134a8e82185d
Author: Jelte Jansen <jelte at isc.org>
Date: Thu Jan 26 16:15:07 2012 +0100
[1573] bit of cleanup
-----------------------------------------------------------------------
Summary of changes:
src/bin/auth/query.h | 3 +++
src/bin/auth/tests/query_unittest.cc | 8 +++-----
2 files changed, 6 insertions(+), 5 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/auth/query.h b/src/bin/auth/query.h
index 897c7fd..e92806b 100644
--- a/src/bin/auth/query.h
+++ b/src/bin/auth/query.h
@@ -78,6 +78,9 @@ private:
/// (signaled by find() returning NXRRSET), and the zone is signed
/// with NSEC, an NSEC denial of existance proof is added.
///
+ /// \exception BadDS raised if find() returns anything other than
+ /// SUCCESS or NXRRSET when searching for the DS
+ /// record.
/// \param finder The ZoneFinder where the delegation was found
/// \param ds_name The name of the delegation RRset
void addDS(isc::datasrc::ZoneFinder& finder,
diff --git a/src/bin/auth/tests/query_unittest.cc b/src/bin/auth/tests/query_unittest.cc
index 0644bcb..c1da52d 100644
--- a/src/bin/auth/tests/query_unittest.cc
+++ b/src/bin/auth/tests/query_unittest.cc
@@ -515,7 +515,6 @@ MockZoneFinder::find(const Name& name, const RRType& type,
}
}
-
// normal cases. names are searched for only per exact-match basis
// for simplicity.
const Domains::const_iterator found_domain = domains_.find(name);
@@ -937,9 +936,8 @@ TEST_F(QueryTest, delegation) {
}
TEST_F(QueryTest, secureDelegation) {
- // find match rrset, omit additional data which has already been provided
- // in the answer section from the additional.
- EXPECT_NO_THROW(Query(memory_client, Name("foo.signed-delegation.example.com"),
+ EXPECT_NO_THROW(Query(memory_client,
+ Name("foo.signed-delegation.example.com"),
qtype, response, true).process());
// Should now contain RRSIG and DS record as well.
@@ -957,7 +955,7 @@ TEST_F(QueryTest, secureUnsignedDelegation) {
Name("foo.unsigned-delegation.example.com"),
qtype, response, true).process());
- // Should now contain RRSIG and DS record as well.
+ // Should now contain RRSIG and NSEC record as well.
responseCheck(response, Rcode::NOERROR(), 0, 0, 3, 0,
NULL,
(string(unsigned_delegation_txt) +
More information about the bind10-changes
mailing list