BIND 10 trac1574, updated. a8c8f392aa951115313dc35159896fe506742079 [1574] an editorial cleanup: moved ToUpper above places where it's used (not mandatory to compile, but the previous position looked awkward)
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Jan 30 18:13:45 UTC 2012
The branch, trac1574 has been updated
via a8c8f392aa951115313dc35159896fe506742079 (commit)
from 1639806c250603b964f79a528285d3c3d20853cd (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a8c8f392aa951115313dc35159896fe506742079
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Mon Jan 30 10:12:37 2012 -0800
[1574] an editorial cleanup: moved ToUpper above places where it's used
(not mandatory to compile, but the previous position looked awkward)
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/memory_datasrc.cc | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory_datasrc.cc b/src/lib/datasrc/memory_datasrc.cc
index 712e86a..9729e8b 100644
--- a/src/lib/datasrc/memory_datasrc.cc
+++ b/src/lib/datasrc/memory_datasrc.cc
@@ -280,6 +280,15 @@ struct InMemoryZoneFinder::InMemoryZoneFinderImpl {
}
}
+ // A helper functor to convert the 1st NSEC3 label to all upper-cased
+ // characters. Note: technically there's a subtle issue when char
+ // is signed, but in practice the label should consist of all positive
+ // character values for a valid NSEC3 hash name (if it's invalid the
+ // resulting zone doesn't work correctly anyway).
+ struct ToUpper {
+ char operator()(char ch) { return (toupper(ch)); }
+ };
+
result::Result addRRsig(const ConstRRsetPtr sig_rrset, ZoneData& zone_data)
{
// Check consistency of the type covered.
@@ -353,15 +362,6 @@ struct InMemoryZoneFinder::InMemoryZoneFinderImpl {
return (result::SUCCESS);
}
- // A helper functor to convert the 1st NSEC3 label to all upper-cased
- // characters. Note: technically there's a subtle issue when char
- // is signed, but in practice the label should consist of all positive
- // character values for a valid NSEC3 hash name (if it's invalid the
- // resulting zone doesn't work correctly anyway).
- struct ToUpper {
- char operator()(char ch) { return (toupper(ch)); }
- };
-
result::Result addNSEC3(const ConstRRsetPtr rrset, ZoneData& zone_data) {
if (!zone_data.nsec3_data_) {
zone_data.nsec3_data_.reset(new ZoneData::NSEC3Data);
More information about the bind10-changes
mailing list