BIND 10 trac2086, updated. c05a571aabb21d44e0d35632327ad96fb52582c3 [2086] Cleanups
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Jul 9 07:52:05 UTC 2012
The branch, trac2086 has been updated
via c05a571aabb21d44e0d35632327ad96fb52582c3 (commit)
from 50dc1afa945214cf133502ea600c48bfeb363a7d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c05a571aabb21d44e0d35632327ad96fb52582c3
Author: Jelte Jansen <jelte at isc.org>
Date: Mon Jul 9 09:51:08 2012 +0200
[2086] Cleanups
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/labelsequence.cc | 8 ++------
src/lib/dns/name.h | 31 -------------------------------
2 files changed, 2 insertions(+), 37 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/labelsequence.cc b/src/lib/dns/labelsequence.cc
index 351d86b..6e778f4 100644
--- a/src/lib/dns/labelsequence.cc
+++ b/src/lib/dns/labelsequence.cc
@@ -82,11 +82,6 @@ LabelSequence::compare(const LabelSequence& other,
// 'this' and 'other', and also determine the hierarchical relationship
// of the names.
- if ((first_label_ > last_label_) ||
- (other.first_label_ > other.last_label_)) {
- isc_throw(BadValue, "Bad label index ranges were passed");
- }
-
unsigned int nlabels = 0;
int l1 = last_label_ - first_label_;
int l2 = other.last_label_ - other.first_label_;
@@ -117,7 +112,8 @@ LabelSequence::compare(const LabelSequence& other,
if (case_sensitive) {
chdiff = (int)label1 - (int)label2;
} else {
- chdiff = (int)isc::dns::name::internal::maptolower[label1] - (int)isc::dns::name::internal::maptolower[label2];
+ chdiff = (int)isc::dns::name::internal::maptolower[label1] -
+ (int)isc::dns::name::internal::maptolower[label2];
}
if (chdiff != 0) {
diff --git a/src/lib/dns/name.h b/src/lib/dns/name.h
index 92c9c5f..27186d7 100644
--- a/src/lib/dns/name.h
+++ b/src/lib/dns/name.h
@@ -405,37 +405,6 @@ public:
/// comparison result.
NameComparisonResult compare(const Name& other) const;
-private:
- /// \brief Partially compare two <code>Name</code>s.
- ///
- /// This method performs a partial comparison of the
- /// <code>Name</code> and <code>other</code> and returns the result
- /// in the form of a <code>NameComparisonResult</code> object.
- ///
- /// This method can throw the BadValue exception if bad label
- /// indices are passed.
- ///
- /// \param other the right-hand operand to compare against.
- /// \param first_label the left-most label of <code>Name</code> to
- /// begin comparing from.
- /// \param first_label_other the left-most label of
- /// <code>other</code> to begin comparing from.
- /// \param last_label the right-most label of <code>Name</code> to
- /// end comparing at.
- /// \param last_label_other the right-most label of
- /// <code>other</code> to end comparing at.
- /// \param case_sensitive If true, comparison is case-insensitive
- /// \return a <code>NameComparisonResult</code> object representing the
- /// comparison result.
-/*
- NameComparisonResult compare(const Name& other,
- unsigned int first_label,
- unsigned int first_label_other,
- unsigned int last_label,
- unsigned int last_label_other,
- bool case_sensitive = false) const;
-*/
-
public:
/// \brief Return true iff two names are equal.
///
More information about the bind10-changes
mailing list