BIND 10 trac2090, updated. 118ceb3b2229743a4f9ef8e9330bdbc278a7dbb9 [2090] Fix the segfault

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Jul 19 11:50:13 UTC 2012


The branch, trac2090 has been updated
       via  118ceb3b2229743a4f9ef8e9330bdbc278a7dbb9 (commit)
      from  b2395c8531d40b25eeb520c76379ffdead02a2ef (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 118ceb3b2229743a4f9ef8e9330bdbc278a7dbb9
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Thu Jul 19 13:49:16 2012 +0200

    [2090] Fix the segfault
    
    There was confusion about left_ and right_. After all, the left and
    right depends on your point of view and on how many mirrors there are
    around.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/rbtree.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/rbtree.h b/src/lib/datasrc/rbtree.h
index d777bf8..95e2586 100644
--- a/src/lib/datasrc/rbtree.h
+++ b/src/lib/datasrc/rbtree.h
@@ -1410,7 +1410,7 @@ RBTree<T>::insert(const isc::dns::Name& target_name, RBNode<T>** new_node) {
     }
 
     typename RBNode<T>::RBNodePtr* current_root = (up_node != NULLNODE) ?
-        &up_node->down_ : &root_;
+        &(up_node->down_) : &root_;
     // using auto_ptr here is avoid memory leak in case of exceptoin raised
     // after the RBNode creation, if we can make sure no exception will be
     // raised until the end of the function, we can remove it for optimization
@@ -1548,7 +1548,7 @@ RBTree<T>::rightRotate(typename RBNode<T>::RBNodePtr* root, RBNode<T>* node) {
 
     if (node->parent_ != NULLNODE) {
         if (node == node->getParent()->getRight()) {
-            node->getParent()->left_ = left;
+            node->getParent()->right_ = left;
         } else  {
             node->getParent()->left_ = left;
         }



More information about the bind10-changes mailing list