BIND 10 trac2091a, created. 5b7ac017e39647e49e3ecbaa874092b0028449e1 [2091a] added revised version of LabelSequence (de)serialization

[BIND 10 source code commits]

The branch, trac2091a has been created
        at  5b7ac017e39647e49e3ecbaa874092b0028449e1 (commit)

- Log -----------------------------------------------------------------
commit 5b7ac017e39647e49e3ecbaa874092b0028449e1
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 18:30:32 2012 -0700

    [2091a] added revised version of LabelSequence (de)serialization

commit 9cc4ac55654683d19af4b55e651d486626f583e8
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 15:09:35 2012 -0700

    [2091a] refactor LabelSequence: ensure last_label_ is always valid index.
    
    This simplifies some internal part of the code, and eliminates the need for
    offsets_size_ (so it's removed).  This change is a preparation for making
    the "from raw data" construction more generic to support non absolute labels.
    This is a purely internal refactoring, and public interfaces aren't changed.

commit f5f665b93cb2f1b1d03a8b5de23c4672cff497d6
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 14:39:41 2012 -0700

    [2091a] overall documentation update for name/labelseq comparison

commit 34f0efc4296a8e142b90d862a983b2452e5c46a8
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 14:19:32 2012 -0700

    [2091a] even further simplification; no need for explicit absolute check.
    
    if one is absoulte and the other is not, they won't have common labels,
    so the main logic can detect their relationship is NONE.  We don't need
    to handle this case separately for performance (if that was the reason)
    because we generally don't expect to do this type of mismatch comparison.
    
    unit tests need to be adjusted because the order is now non 0.

commit f554bfb2cfc6b108e253214aae99fbdd7f75593c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 14:06:38 2012 -0700

    [2091a] removed a redundant condition.
    
    if nlabels == 0, it must not be absolute because otherwise the other
    should also be absolute, in which case nlabes != 0.

commit 0c5ac6b64b8100e5446fd48ba8eae43b25157485
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 12:26:32 2012 -0700

    [2091a] updated LabelSequence::compare() for the NONE-relationship cases.
    
    the originally intended behavior was to return non 0 order for these cases,
    so this point was adjusted.
    the code was also simplified by removing unnecessary conditions like:
    -                     ((last_label_ < getLabelCount()) ||
    -                      (other.last_label_ < other.getLabelCount())))) {
    
    this is meaningless because getLabelCount() is last_label_ - first_label_,
    so the codntion is actually first_label_ < 0, which is always false.
    whatever the real intent of this condition was, such additional checks
    didn't seem to be necessary for the intended behavior of compare() anyway,
    so I simply removed them.
    some test cases were adjusted for the change, and some were added to confirm
    related cases that were not tested before.

commit b8eb94ff7d736acaa5e8a1f09044617e66958a5d
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri Jul 20 00:58:05 2012 -0700

    [2091a] cleanup: constify; brace; C++ cast

commit 9256f0d5a0cc43f87ebfb80588687221aca7b3fa
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Jul 18 15:29:17 2012 -0700

    [2091a] [2094] (unrelated cleanup) use the term 'copy constructor' to mean it.
    
    and remove the unnecessary 'explicit' from it ('non-explicit' usage
    wouldn't be a copy constructor in the first place).

-----------------------------------------------------------------------