BIND 10 trac2092_2, updated. ae25a3ba4de7364d18acc96f06303312eb3ac7b2 [2092] Add comment about pointer dereference asked by reviewer

BIND 10 source code commits bind10-changes at lists.isc.org
Sun Jul 29 17:54:55 UTC 2012


The branch, trac2092_2 has been updated
       via  ae25a3ba4de7364d18acc96f06303312eb3ac7b2 (commit)
      from  8cbfc95d3ce3a5d15acfe603ea8816a7dc04febe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae25a3ba4de7364d18acc96f06303312eb3ac7b2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Sun Jul 29 23:24:31 2012 +0530

    [2092] Add comment about pointer dereference asked by reviewer

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/rbtree.h |    2 ++
 1 file changed, 2 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/rbtree.h b/src/lib/datasrc/rbtree.h
index c3e9fd3..5db7d08 100644
--- a/src/lib/datasrc/rbtree.h
+++ b/src/lib/datasrc/rbtree.h
@@ -1544,6 +1544,8 @@ RBTree<T>::insertRebalance(typename RBNode<T>::RBNodePtr* root,
     RBNode<T>* parent;
     while (node != (*root).get() &&
            (parent = node->getParent())->getColor() == RBNode<T>::RED) {
+        // Here, node->parent_ is not NULL and it is also red, so
+        // node->parent_->parent_ is also not NULL.
         if (parent == parent->getParent()->getLeft()) {
             uncle = parent->getParent()->getRight();
 



More information about the bind10-changes mailing list