BIND 10 trac1513, updated. 68b33af1da81765fe4f390ca3b6d9a8959736e3c [1513] InternalError is local to DDNSServer, so need 'self' to refer to it.

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Jun 6 00:05:42 UTC 2012


The branch, trac1513 has been updated
       via  68b33af1da81765fe4f390ca3b6d9a8959736e3c (commit)
      from  f378dbd066722c41f39718cf26ec0282645896e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 68b33af1da81765fe4f390ca3b6d9a8959736e3c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Jun 5 17:04:53 2012 -0700

    [1513] InternalError is local to DDNSServer, so need 'self' to refer to it.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/ddns/ddns.py.in |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/ddns/ddns.py.in b/src/bin/ddns/ddns.py.in
index 1a4746d..9c432f4 100755
--- a/src/bin/ddns/ddns.py.in
+++ b/src/bin/ddns/ddns.py.in
@@ -305,8 +305,8 @@ class DDNSServer:
                                isc.server_common.tsig_keyring.get_keyring())
         tsig_error = tsig_ctx.verify(tsig_record, req_data)
         if tsig_error != TSIGError.NOERROR:
-            raise InternalError("Failed to verify request's TSIG: " +
-                                str(tsig_error))
+            raise self.InternalError("Failed to verify request's TSIG: " +
+                                     str(tsig_error))
         return tsig_ctx
 
     def handle_request(self, req_session):
@@ -343,13 +343,14 @@ class DDNSServer:
         # as an internal error and don't bother to respond.
         try:
             if sock.proto == socket.IPPROTO_TCP:
-                raise InternalError('TCP requests are not yet supported')
+                raise self.InternalError('TCP requests are not yet supported')
             self.__request_msg.clear(Message.PARSE)
             # specify PRESERVE_ORDER as we need to handle each RR separately.
             self.__request_msg.from_wire(req_data, Message.PRESERVE_ORDER)
             if self.__request_msg.get_opcode() != Opcode.UPDATE():
-                raise InternalError('Update request has unexpected opcode: ' +
-                                    str(self.__request_msg.get_opcode()))
+                raise self.InternalError('Update request has unexpected '
+                                         'opcode: ' +
+                                         str(self.__request_msg.get_opcode()))
             tsig_ctx = self.__check_request_tsig(self.__request_msg, req_data)
         except Exception as ex:
             logger.error(DDNS_REQUEST_PARSE_FAIL, ex)



More information about the bind10-changes mailing list