BIND 10 trac2027, updated. dcafee23dccbdf2f4b77ffc57d4a485ab4334455 [2027] update rationale comment about acl check
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Jun 15 07:51:46 UTC 2012
The branch, trac2027 has been updated
via dcafee23dccbdf2f4b77ffc57d4a485ab4334455 (commit)
from d84cc75031f45e6a11c06775443f860d46282567 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit dcafee23dccbdf2f4b77ffc57d4a485ab4334455
Author: Jelte Jansen <jelte at isc.org>
Date: Fri Jun 15 09:51:27 2012 +0200
[2027] update rationale comment about acl check
-----------------------------------------------------------------------
Summary of changes:
src/lib/python/isc/ddns/session.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/ddns/session.py b/src/lib/python/isc/ddns/session.py
index 5cadb60..366bc8b 100644
--- a/src/lib/python/isc/ddns/session.py
+++ b/src/lib/python/isc/ddns/session.py
@@ -243,8 +243,10 @@ class UpdateSession:
try:
self._get_update_zone()
# Contrary to what RFC2136 specifies, we do ACL checks before
- # prerequisites. Following the spec, information could leak,
- # and we decided not to do so (as do other implementations)
+ # prerequisites. It's now generally considered to be a bad
+ # idea, and actually does harm such as information
+ # leak. It should make more sense to prevent any security issues
+ # by performing ACL check as early as possible.
self.__check_update_acl(self.__zname, self.__zclass)
self._create_diff()
prereq_result = self.__check_prerequisites()
More information about the bind10-changes
mailing list