BIND 10 master, updated. 0557f306a4d0accdd5b6510466749f99073a78f5 Merge branch 'master' into trac2036

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Jun 18 10:42:59 UTC 2012


The branch, master has been updated
       via  0557f306a4d0accdd5b6510466749f99073a78f5 (commit)
       via  f57a34bf713fc0f11898f7ec79eb4ea895bb3f73 (commit)
       via  80d9f838002501ee277ecdac7b583c0dfffe6aaf (commit)
       via  3039e3cd0ae47a6434b18423a45497b7c45e7164 (commit)
       via  61814fef6b44445aa95f568dd643dd70243a15b5 (commit)
       via  9e0c33a521c1aee0f6f553de7ddca3ebbc51837d (commit)
       via  05cfa4f1a83966748dcc8a7b5aa0287f68d5e126 (commit)
       via  4b56c8149ebf215d09c3c38a520d64b6ef8a89dc (commit)
       via  a7d656ede2059f6ea2f1124d69e963cc07c79d33 (commit)
       via  3317bd6b1575ce0114a6797c5eb727a0978770de (commit)
       via  d45ad9c3684ef7bfc9b032444377b6335d3e205a (commit)
       via  818dd92ad577ce2b5029cf8a838fab067bcab109 (commit)
       via  a66e8c4e5d8278302fecf7609b76d5aa944e723c (commit)
       via  090ccd31e4107b58dd8d65bae744e0b158f999ff (commit)
       via  c4906480aa8458ecee8194e501c17fc753bc0dad (commit)
       via  0bb55bab34119c6aadce1221f75ec148b28401a1 (commit)
      from  333138055635992ef6e04484010d4e491edd888f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0557f306a4d0accdd5b6510466749f99073a78f5
Merge: f57a34b 3331380
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Jun 18 15:55:12 2012 +0530

    Merge branch 'master' into trac2036

commit f57a34bf713fc0f11898f7ec79eb4ea895bb3f73
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Jun 18 15:46:22 2012 +0530

    [2036] Empty the suppressions list for now
    
    We will add suppressions to this list from a single buildbot that is
    running a distribution which is supported well into the future (some EL
    or LTS variant). Hopefully, this will keep the stacks in the
    suppressions identical without many changes.

commit 80d9f838002501ee277ecdac7b583c0dfffe6aaf
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Jun 14 17:22:02 2012 +0530

    [2036] Track origins of uninitialized memory when not running on a build machine

commit 3039e3cd0ae47a6434b18423a45497b7c45e7164
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 14:08:17 2012 +0530

    [2036] Introduce --enable-valgrind-suppressions configure switch
    
    The rationale for this is:
    
    * Developers configure with `--enable-valgrind` and run `make check` to
      see all the error reports (`make check` continues testing even if
      there are Valgrind issues). This encourages us to fix these issues,
      especially if we are modifying those parts of the code as part of
      another bug.
    
    * Builders configure with `--enable-valgrind
      --enable-valgrind-suppressions` and run `make check` with
      suppressions. `make check` doesn't show existing suppressed issues and
      stops building if it finds a new Valgrind issue that is not
      suppressed.

commit 61814fef6b44445aa95f568dd643dd70243a15b5
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:37:21 2012 +0530

    [2036] Show even deeper stacks

commit 9e0c33a521c1aee0f6f553de7ddca3ebbc51837d
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:38:13 2012 +0530

    Revert "[2036] Show even deeper stacks"
    
    This reverts commit 05cfa4f1a83966748dcc8a7b5aa0287f68d5e126.

commit 05cfa4f1a83966748dcc8a7b5aa0287f68d5e126
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:37:21 2012 +0530

    [2036] Show even deeper stacks

commit 4b56c8149ebf215d09c3c38a520d64b6ef8a89dc
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:36:34 2012 +0530

    [2036] Add a note about not using obj: lines in suppressions

commit a7d656ede2059f6ea2f1124d69e963cc07c79d33
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:07:03 2012 +0530

    [2036] Add suppressions for all existing issues reported by Valgrind

commit 3317bd6b1575ce0114a6797c5eb727a0978770de
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jun 13 04:05:53 2012 +0530

    [2036] Return non-zero exit status when valgrind finds an issue
    
    This should work fine with make check, so long as we have all issues
    fixed or covered by suppressions. In this case, whenever a new issue
    is introduced, make check would fail.

commit d45ad9c3684ef7bfc9b032444377b6335d3e205a
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 21:55:00 2012 +0530

    Add comment about demangling symbols in the suppressions

commit 818dd92ad577ce2b5029cf8a838fab067bcab109
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 21:43:30 2012 +0530

    [2036] Turn off fd-related reports for now

commit a66e8c4e5d8278302fecf7609b76d5aa944e723c
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 21:40:57 2012 +0530

    [2036] Make valgrind run quietly so it looks like a regular make check
    
    ... except when there are issues.

commit 090ccd31e4107b58dd8d65bae744e0b158f999ff
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 19:42:31 2012 +0530

    [2036] Show valgrind use status in configure output

commit c4906480aa8458ecee8194e501c17fc753bc0dad
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 16:43:38 2012 +0530

    [2036] Show deeper stack

commit 0bb55bab34119c6aadce1221f75ec148b28401a1
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jun 12 16:29:15 2012 +0530

    [2036] Integrate valgrind into our test suite
    
    * Supply --enable-valgrind to configure to run tests (make check)
      under valgrind
    
    * Use two classes of suppressions files:
     + src/valgrind-suppressions for permanent suppressions that we
       never want to re-consider again
     + src/valgrind-suppressions.revisit for temporary suppressions
      (such as issues in testcases) that are not a priority to fix,
      but we'd like to fix them sometime

-----------------------------------------------------------------------

Summary of changes:
 configure.ac                            |   26 ++++++++++++++++++++++++++
 src/Makefile.am                         |    5 +++++
 src/bin/auth/tests/Makefile.am          |    3 +++
 src/bin/dhcp4/tests/Makefile.am         |    3 +++
 src/bin/dhcp6/tests/Makefile.am         |    3 +++
 src/bin/resolver/tests/Makefile.am      |    3 +++
 src/bin/sockcreator/tests/Makefile.am   |    3 +++
 src/lib/acl/tests/Makefile.am           |    3 +++
 src/lib/asiodns/tests/Makefile.am       |    3 +++
 src/lib/asiolink/tests/Makefile.am      |    3 +++
 src/lib/bench/tests/Makefile.am         |    3 +++
 src/lib/cache/tests/Makefile.am         |    3 +++
 src/lib/cc/tests/Makefile.am            |    3 +++
 src/lib/config/tests/Makefile.am        |    3 +++
 src/lib/cryptolink/tests/Makefile.am    |    3 +++
 src/lib/datasrc/tests/Makefile.am       |    3 +++
 src/lib/dhcp/tests/Makefile.am          |    3 +++
 src/lib/dns/tests/Makefile.am           |    3 +++
 src/lib/exceptions/tests/Makefile.am    |    3 +++
 src/lib/log/tests/Makefile.am           |    3 +++
 src/lib/nsas/tests/Makefile.am          |    3 +++
 src/lib/resolve/tests/Makefile.am       |    3 +++
 src/lib/server_common/tests/Makefile.am |    3 +++
 src/lib/statistics/tests/Makefile.am    |    3 +++
 src/lib/util/tests/Makefile.am          |    3 +++
 src/lib/xfr/tests/Makefile.am           |    3 +++
 src/valgrind-suppressions               |   11 +++++++++++
 src/valgrind-suppressions.revisit       |   17 +++++++++++++++++
 tests/tools/badpacket/tests/Makefile.am |    3 +++
 tests/tools/perfdhcp/tests/Makefile.am  |    3 +++
 30 files changed, 137 insertions(+)
 create mode 100644 src/valgrind-suppressions
 create mode 100644 src/valgrind-suppressions.revisit

-----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index f5a772a..fe95c92 100644
--- a/configure.ac
+++ b/configure.ac
@@ -982,6 +982,30 @@ AC_ARG_ENABLE(logger-checks, [AC_HELP_STRING([--enable-logger-checks],
 AM_CONDITIONAL(ENABLE_LOGGER_CHECKS, test x$enable_logger_checks != xno)
 AM_COND_IF([ENABLE_LOGGER_CHECKS], [AC_DEFINE([ENABLE_LOGGER_CHECKS], [1], [Check logger messages?])])
 
+# Check for valgrind
+AC_PATH_PROG(VALGRIND, valgrind, no)
+AM_CONDITIONAL(HAVE_VALGRIND, test "x$VALGRIND" != "xno")
+
+AC_ARG_ENABLE(valgrind, [AC_HELP_STRING([--enable-valgrind],
+  [run tests under Valgrind [default=no]])], enable_valgrind=$enableval, enable_valgrind=no)
+AC_ARG_ENABLE(valgrind-suppressions, [AC_HELP_STRING([--enable-valgrind-suppressions],
+  [enable Valgrind suppressions [default=no]])], enable_valgrind_suppressions=$enableval, enable_valgrind_suppressions=no)
+
+use_valgrind=no
+use_valgrind_suppressions=no
+
+if test "x$VALGRIND" != "xno" -a "x$enable_valgrind" != "xno"; then
+   if test "x$enable_valgrind_suppressions" != "xno"; then
+      VALGRIND_EXTRA="--error-exitcode=1 --suppressions=\$(top_srcdir)/src/valgrind-suppressions --suppressions=\$(top_srcdir)/src/valgrind-suppressions.revisit"
+      use_valgrind_suppressions=yes
+   else
+      VALGRIND_EXTRA="--track-origins=yes"
+   fi
+   VALGRIND_COMMAND="$VALGRIND -q --gen-suppressions=all $VALGRIND_EXTRA --num-callers=48 --leak-check=full --fullpath-after="
+   use_valgrind=yes
+fi
+AC_SUBST(VALGRIND_COMMAND)
+
 AC_CONFIG_FILES([Makefile
                  doc/Makefile
                  doc/guide/Makefile
@@ -1292,6 +1316,8 @@ Features:
 
 Developer:
   Google Tests:  $gtest_path
+  Valgrind: $use_valgrind
+  Valgrind Suppressions: $use_valgrind_suppressions
   C++ Code Coverage: $USE_LCOV
   Python Code Coverage: $USE_PYCOVERAGE
   Logger checks: $enable_logger_checks
diff --git a/src/Makefile.am b/src/Makefile.am
index ca4a702..395553c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1 +1,6 @@
 SUBDIRS = lib bin
+
+EXTRA_DIST = \
+	cppcheck-suppress.lst		\
+	valgrind-suppressions		\
+	valgrind-suppressions.revisit
diff --git a/src/bin/auth/tests/Makefile.am b/src/bin/auth/tests/Makefile.am
index 4b6621e..84fd5fa 100644
--- a/src/bin/auth/tests/Makefile.am
+++ b/src/bin/auth/tests/Makefile.am
@@ -19,6 +19,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 # Do not define global tests, use check-local so
 # environment can be set (needed for dynamic loading)
 TESTS =
diff --git a/src/bin/dhcp4/tests/Makefile.am b/src/bin/dhcp4/tests/Makefile.am
index 07de393..997aea2 100644
--- a/src/bin/dhcp4/tests/Makefile.am
+++ b/src/bin/dhcp4/tests/Makefile.am
@@ -38,6 +38,9 @@ if USE_STATIC_LINK
 AM_LDFLAGS = -static
 endif
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 
diff --git a/src/bin/dhcp6/tests/Makefile.am b/src/bin/dhcp6/tests/Makefile.am
index c1a8f3c..ab247bc 100644
--- a/src/bin/dhcp6/tests/Makefile.am
+++ b/src/bin/dhcp6/tests/Makefile.am
@@ -34,6 +34,9 @@ if USE_STATIC_LINK
 AM_LDFLAGS = -static
 endif
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 
diff --git a/src/bin/resolver/tests/Makefile.am b/src/bin/resolver/tests/Makefile.am
index 4d407bb..af3fcd3 100644
--- a/src/bin/resolver/tests/Makefile.am
+++ b/src/bin/resolver/tests/Makefile.am
@@ -14,6 +14,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/bin/sockcreator/tests/Makefile.am b/src/bin/sockcreator/tests/Makefile.am
index ef518b5..cc5959c 100644
--- a/src/bin/sockcreator/tests/Makefile.am
+++ b/src/bin/sockcreator/tests/Makefile.am
@@ -8,6 +8,9 @@ if USE_STATIC_LINK
 AM_LDFLAGS = -static
 endif
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/acl/tests/Makefile.am b/src/lib/acl/tests/Makefile.am
index 6369511..6df91c7 100644
--- a/src/lib/acl/tests/Makefile.am
+++ b/src/lib/acl/tests/Makefile.am
@@ -8,6 +8,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/asiodns/tests/Makefile.am b/src/lib/asiodns/tests/Makefile.am
index 95094f0..a96a3e6 100644
--- a/src/lib/asiodns/tests/Makefile.am
+++ b/src/lib/asiodns/tests/Makefile.am
@@ -12,6 +12,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/asiolink/tests/Makefile.am b/src/lib/asiolink/tests/Makefile.am
index eaa2173..39b098d 100644
--- a/src/lib/asiolink/tests/Makefile.am
+++ b/src/lib/asiolink/tests/Makefile.am
@@ -18,6 +18,9 @@ AM_CXXFLAGS += $(WARNING_NO_MISSING_FIELD_INITIALIZERS_CFLAG)
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/bench/tests/Makefile.am b/src/lib/bench/tests/Makefile.am
index 3f8a678..8069559 100644
--- a/src/lib/bench/tests/Makefile.am
+++ b/src/lib/bench/tests/Makefile.am
@@ -5,6 +5,9 @@ AM_CXXFLAGS = $(B10_CXXFLAGS)
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/cache/tests/Makefile.am b/src/lib/cache/tests/Makefile.am
index b638f55..fe33d3c 100644
--- a/src/lib/cache/tests/Makefile.am
+++ b/src/lib/cache/tests/Makefile.am
@@ -28,6 +28,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/cc/tests/Makefile.am b/src/lib/cc/tests/Makefile.am
index e49b599..b891628 100644
--- a/src/lib/cc/tests/Makefile.am
+++ b/src/lib/cc/tests/Makefile.am
@@ -16,6 +16,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/config/tests/Makefile.am b/src/lib/config/tests/Makefile.am
index 2f1fc6f..1d9bad8 100644
--- a/src/lib/config/tests/Makefile.am
+++ b/src/lib/config/tests/Makefile.am
@@ -14,6 +14,9 @@ CLEANFILES = *.gcno *.gcda
 noinst_LTLIBRARIES = libfake_session.la
 libfake_session_la_SOURCES = fake_session.h fake_session.cc
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/cryptolink/tests/Makefile.am b/src/lib/cryptolink/tests/Makefile.am
index fbe1bad..be2f4d6 100644
--- a/src/lib/cryptolink/tests/Makefile.am
+++ b/src/lib/cryptolink/tests/Makefile.am
@@ -10,6 +10,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/datasrc/tests/Makefile.am b/src/lib/datasrc/tests/Makefile.am
index 1a54d49..e72fd71 100644
--- a/src/lib/datasrc/tests/Makefile.am
+++ b/src/lib/datasrc/tests/Makefile.am
@@ -17,6 +17,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 noinst_PROGRAMS =
 if HAVE_GTEST
diff --git a/src/lib/dhcp/tests/Makefile.am b/src/lib/dhcp/tests/Makefile.am
index 4c86ee7..13e8458 100644
--- a/src/lib/dhcp/tests/Makefile.am
+++ b/src/lib/dhcp/tests/Makefile.am
@@ -19,6 +19,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += libdhcp++_unittests
diff --git a/src/lib/dns/tests/Makefile.am b/src/lib/dns/tests/Makefile.am
index 6057828..208c7ef 100644
--- a/src/lib/dns/tests/Makefile.am
+++ b/src/lib/dns/tests/Makefile.am
@@ -14,6 +14,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/exceptions/tests/Makefile.am b/src/lib/exceptions/tests/Makefile.am
index 2444b02..28af100 100644
--- a/src/lib/exceptions/tests/Makefile.am
+++ b/src/lib/exceptions/tests/Makefile.am
@@ -9,6 +9,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/log/tests/Makefile.am b/src/lib/log/tests/Makefile.am
index 9742037..615f64b 100644
--- a/src/lib/log/tests/Makefile.am
+++ b/src/lib/log/tests/Makefile.am
@@ -47,6 +47,9 @@ logger_lock_test_LDADD += $(top_builddir)/src/lib/util/libutil.la
 logger_lock_test_LDADD += $(top_builddir)/src/lib/exceptions/libexceptions.la
 logger_lock_test_LDADD += $(AM_LDADD) $(LOG4CPLUS_LIBS)
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 if HAVE_GTEST
 TESTS =
 
diff --git a/src/lib/nsas/tests/Makefile.am b/src/lib/nsas/tests/Makefile.am
index afd91f6..3557c82 100644
--- a/src/lib/nsas/tests/Makefile.am
+++ b/src/lib/nsas/tests/Makefile.am
@@ -25,6 +25,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+	libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/resolve/tests/Makefile.am b/src/lib/resolve/tests/Makefile.am
index e7c59f4..4ee3811 100644
--- a/src/lib/resolve/tests/Makefile.am
+++ b/src/lib/resolve/tests/Makefile.am
@@ -8,6 +8,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/server_common/tests/Makefile.am b/src/lib/server_common/tests/Makefile.am
index b059d47..366c68e 100644
--- a/src/lib/server_common/tests/Makefile.am
+++ b/src/lib/server_common/tests/Makefile.am
@@ -22,6 +22,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/statistics/tests/Makefile.am b/src/lib/statistics/tests/Makefile.am
index d66acdf..c0f0295 100644
--- a/src/lib/statistics/tests/Makefile.am
+++ b/src/lib/statistics/tests/Makefile.am
@@ -15,6 +15,9 @@ AM_CXXFLAGS += $(WARNING_NO_MISSING_FIELD_INITIALIZERS_CFLAG)
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/util/tests/Makefile.am b/src/lib/util/tests/Makefile.am
index cf1e5a5..a7811d5 100644
--- a/src/lib/util/tests/Makefile.am
+++ b/src/lib/util/tests/Makefile.am
@@ -15,6 +15,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/lib/xfr/tests/Makefile.am b/src/lib/xfr/tests/Makefile.am
index 4abb456..d8f3933 100644
--- a/src/lib/xfr/tests/Makefile.am
+++ b/src/lib/xfr/tests/Makefile.am
@@ -8,6 +8,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/src/valgrind-suppressions b/src/valgrind-suppressions
new file mode 100644
index 0000000..06257e5
--- /dev/null
+++ b/src/valgrind-suppressions
@@ -0,0 +1,11 @@
+# Valgrind suppressions file. Place permanent suppressions that we never
+# want to reconsider again into this file. For temporary suppressions
+# that we want to revisit in the future, use
+# valgrind-suppressions.revisit.
+#
+# Don't add any "obj:" lines in suppressions as these are likely
+# site-specific. Use "..." instead to match these. Look at the other
+# suppressions as examples.
+#
+# In case you want to make sense of the following symbols, demangle them
+# with a command like: c++filt < valgrind-suppressions
diff --git a/src/valgrind-suppressions.revisit b/src/valgrind-suppressions.revisit
new file mode 100644
index 0000000..8b4a8c7
--- /dev/null
+++ b/src/valgrind-suppressions.revisit
@@ -0,0 +1,17 @@
+# Place temporary suppressions that we want to revisit in the future
+# into this file. For permanent suppressions that we don't want to look
+# at again, use valgrind-suppressions.
+#
+# Don't add any "obj:" lines in suppressions as these are likely
+# site-specific. Use "..." instead to match these. Look at the other
+# suppressions as examples.
+#
+# In case you want to make sense of the following symbols, demangle them
+# with a command like: c++filt < valgrind-suppressions.revisit
+
+############################################################################
+#### beginning of suppressions for existing issues that we want to fix. ####
+
+
+####### end of suppressions for existing issues that we want to fix. #######
+############################################################################
diff --git a/tests/tools/badpacket/tests/Makefile.am b/tests/tools/badpacket/tests/Makefile.am
index 2daa664..bf70669 100644
--- a/tests/tools/badpacket/tests/Makefile.am
+++ b/tests/tools/badpacket/tests/Makefile.am
@@ -10,6 +10,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
diff --git a/tests/tools/perfdhcp/tests/Makefile.am b/tests/tools/perfdhcp/tests/Makefile.am
index d4034b3..21e5b46 100644
--- a/tests/tools/perfdhcp/tests/Makefile.am
+++ b/tests/tools/perfdhcp/tests/Makefile.am
@@ -10,6 +10,9 @@ endif
 
 CLEANFILES = *.gcno *.gcda
 
+TESTS_ENVIRONMENT = \
+        libtool --mode=execute $(VALGRIND_COMMAND)
+
 TESTS =
 if HAVE_GTEST
 TESTS += run_unittests



More information about the bind10-changes mailing list