BIND 10 trac2044, updated. afddf8828805e696c391be55105f620ae4840b4c [1044] Cleanups, style, comments

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Jun 26 15:23:26 UTC 2012


The branch, trac2044 has been updated
       via  afddf8828805e696c391be55105f620ae4840b4c (commit)
      from  cd6b6e00ddc1fec370ccc55c3c84e082850fb29d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit afddf8828805e696c391be55105f620ae4840b4c
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Jun 26 17:23:16 2012 +0200

    [1044] Cleanups, style, comments

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/client_list.cc |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/client_list.cc b/src/lib/datasrc/client_list.cc
index 3e57cf0..fab534d 100644
--- a/src/lib/datasrc/client_list.cc
+++ b/src/lib/datasrc/client_list.cc
@@ -40,7 +40,7 @@ ConfigurableClientList::DataSourceInfo::DataSourceInfo(
 }
 
 void
-ConfigurableClientList::configure(const Element& config, bool allowCache) {
+ConfigurableClientList::configure(const Element& config, bool allow_cache) {
     // TODO: Implement recycling from the old configuration.
     size_t i(0); // Outside of the try to be able to access it in the catch
     try {
@@ -62,17 +62,19 @@ ConfigurableClientList::configure(const Element& config, bool allowCache) {
             // Ask the factory to create the data source for us
             const DataSourcePair ds(this->getDataSourceClient(type,
                                                               paramConf));
-            const bool wantCache(allowCache &&
-                                 dconf->contains("cache-enable") &&
-                                 dconf->get("cache-enable")->boolValue());
+            const bool want_cache(allow_cache &&
+                                  dconf->contains("cache-enable") &&
+                                  dconf->get("cache-enable")->boolValue());
             // And put it into the vector
             new_data_sources.push_back(DataSourceInfo(ds.first, ds.second,
-                                                      wantCache));
-            if (wantCache) {
+                                                      want_cache));
+            if (want_cache) {
                 if (!dconf->contains("cache-zones")) {
                     isc_throw(isc::NotImplemented, "Auto-detection of zones "
                               "to cache is not yet implemented, supply "
                               "cache-zones parameter");
+                    // TODO: Auto-detect list of all zones in the
+                    // data source.
                 }
                 const ConstElementPtr zones(dconf->get("cache-zones"));
                 const shared_ptr<InMemoryClient>



More information about the bind10-changes mailing list