BIND 10 trac1608, updated. a2d27b3d05763fa267d6f19cff7468ac86063a38 [1608] avoid returning a reference from getAdditionalName() for safety.

BIND 10 source code commits bind10-changes at lists.isc.org
Sat Mar 10 08:17:35 UTC 2012


The branch, trac1608 has been updated
       via  a2d27b3d05763fa267d6f19cff7468ac86063a38 (commit)
      from  0f0ab5b692e5670b0ff6774d0003a5f676a79dcc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a2d27b3d05763fa267d6f19cff7468ac86063a38
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Sat Mar 10 00:16:12 2012 -0800

    [1608] avoid returning a reference from getAdditionalName() for safety.
    
    In this specific case I believe it was actually safe, but making a copy
    is clearly safer.  And this function doesn't have to be super fast anyway.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory_datasrc.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory_datasrc.cc b/src/lib/datasrc/memory_datasrc.cc
index 744d59b..954f562 100644
--- a/src/lib/datasrc/memory_datasrc.cc
+++ b/src/lib/datasrc/memory_datasrc.cc
@@ -1289,7 +1289,7 @@ InMemoryZoneFinder::add(const ConstRRsetPtr& rrset) {
 
 namespace {
 // This should eventually be more generalized.
-const Name&
+const Name
 getAdditionalName(RRType rrtype, const rdata::Rdata& rdata) {
     if (rrtype == RRType::NS()) {
         const generic::NS& ns = dynamic_cast<const generic::NS&>(rdata);



More information about the bind10-changes mailing list