BIND 10 trac1779, updated. bc67fb7ccb6d655fd46272c1dfd89a0e58677035 [1779] update comment for increased sleep time

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Mar 14 16:51:30 UTC 2012


The branch, trac1779 has been updated
       via  bc67fb7ccb6d655fd46272c1dfd89a0e58677035 (commit)
      from  113f736e002db510897feb1e6e55600d622f9d26 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bc67fb7ccb6d655fd46272c1dfd89a0e58677035
Author: Jelte Jansen <jelte at isc.org>
Date:   Wed Mar 14 17:51:17 2012 +0100

    [1779] update comment for increased sleep time

-----------------------------------------------------------------------

Summary of changes:
 src/lib/cache/tests/negative_cache_unittest.cc |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/cache/tests/negative_cache_unittest.cc b/src/lib/cache/tests/negative_cache_unittest.cc
index 27f713d..4935e4a 100644
--- a/src/lib/cache/tests/negative_cache_unittest.cc
+++ b/src/lib/cache/tests/negative_cache_unittest.cc
@@ -83,6 +83,9 @@ TEST_F(NegativeCacheTest, testNXDOMAIN){
     EXPECT_GE(soa_ttl.getValue(), 172799);
     EXPECT_LE(soa_ttl.getValue(), 172800);
 
+    // Sleep for 2 seconds. 2 seconds to make sure the final range check
+    // does not overlap with the original ones (in which case this test
+    // would erroneously pass if the ttl value is not changed)
     sleep(2);
 
     // Query nonexist.example.com again
@@ -209,6 +212,9 @@ TEST_F(NegativeCacheTest, testNoerrorNodata){
     messageFromFile(msg_nodata2, "message_nodata_with_soa.wire");
     msg_nodata2.makeResponse();
 
+    // Sleep for 2 seconds. 2 seconds to make sure the final range check
+    // does not overlap with the original ones (in which case this test
+    // would erroneously pass if the ttl value is not changed)
     sleep(2);
 
     EXPECT_TRUE(cache->lookup(example_dot_com, RRType::MX(), RRClass::IN(), msg_nodata2));



More information about the bind10-changes mailing list