BIND 10 trac1967, updated. edad8ee1e80c5b35c2f5b3eafe82d56cd0d6e5e9 [1967] ADD_FAILURE() improvements in Dhcpv6SrvTest::DUID

BIND 10 source code commits bind10-changes at lists.isc.org
Mon May 14 14:59:21 UTC 2012


The branch, trac1967 has been updated
       via  edad8ee1e80c5b35c2f5b3eafe82d56cd0d6e5e9 (commit)
      from  7df26862869e043efe8b320d9b0404410f123db0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit edad8ee1e80c5b35c2f5b3eafe82d56cd0d6e5e9
Author: Tomek Mrugalski <tomasz at isc.org>
Date:   Mon May 14 16:58:47 2012 +0200

    [1967] ADD_FAILURE() improvements in Dhcpv6SrvTest::DUID

-----------------------------------------------------------------------

Summary of changes:
 src/bin/dhcp6/tests/dhcp6_srv_unittest.cc |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
index f1e2c3e..f21366d 100644
--- a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
+++ b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
@@ -143,12 +143,18 @@ TEST_F(Dhcpv6SrvTest, DUID) {
     }
     case DUID_LL: {
         // not supported yet
-        cout << "Test not implemented for DUID-LL yet." << endl;
+        cout << "Test not implemented for DUID-LL." << endl;
+
+        // No failure here. There's really no way for test LL DUID. It doesn't
+        // even make sense to check if that Link Layer is actually present on
+        // a physical interface. RFC3315 says a server should write its DUID
+        // and keep it despite hardware changes.
+        break;
     }
     case DUID_UUID: // not supported yet
     default:
-        cout << "Not supported duid type=" << duid_type << endl;
-        ADD_FAILURE();
+        ADD_FAILURE() << "Not supported duid type=" << duid_type << endl;
+        break;
     }
     delete srv; // destructor will close sockets, causing next test to succeed
 }



More information about the bind10-changes mailing list