BIND 10 trac1539-2, updated. ad6c12af58714d9c72f7726a598b24fc81ba03fd [1539] added some note about sockaddr conversion

BIND 10 source code commits bind10-changes at lists.isc.org
Sat May 19 02:36:26 UTC 2012


The branch, trac1539-2 has been updated
       via  ad6c12af58714d9c72f7726a598b24fc81ba03fd (commit)
      from  921405b03235bb9f610f3f432f3a59b4fb598b1b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ad6c12af58714d9c72f7726a598b24fc81ba03fd
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Fri May 18 19:36:13 2012 -0700

    [1539] added some note about sockaddr conversion

-----------------------------------------------------------------------

Summary of changes:
 src/lib/util/unittests/mock_socketsession.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/util/unittests/mock_socketsession.h b/src/lib/util/unittests/mock_socketsession.h
index 9fa9a19..8078265 100644
--- a/src/lib/util/unittests/mock_socketsession.h
+++ b/src/lib/util/unittests/mock_socketsession.h
@@ -111,6 +111,11 @@ public:
     // Read-only accessors to recorded parameters to the previous successful
     // call to push().  Return values are undefined if there has been no
     // successful call to push().
+    // Note that we use convertSockAddr() to convert sockaddr_storage to
+    // sockaddr.  It should be safe since we use the storage in its literal
+    // sense; it was originally filled with the binary image of another
+    // sockaddr structure, and we are going to return the image opaquely
+    // as a sockaddr structure without touching the data.
     int getPushedSock() const { return (pushed_sock_); }
     int getPushedFamily() const { return (pushed_family_); }
     int getPushedType() const { return (pushed_type_); }



More information about the bind10-changes mailing list