BIND 10 trac1512, updated. be4044ab9ca0163c7a736a1baa045f3b9192f11a [1512] added note about overhead tradeoff for the formatter classes.
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed May 23 16:35:48 UTC 2012
The branch, trac1512 has been updated
via be4044ab9ca0163c7a736a1baa045f3b9192f11a (commit)
from e2706e3bf587ca97983e0115e998904d9d0cc674 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit be4044ab9ca0163c7a736a1baa045f3b9192f11a
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed May 23 09:35:28 2012 -0700
[1512] added note about overhead tradeoff for the formatter classes.
-----------------------------------------------------------------------
Summary of changes:
src/lib/python/isc/ddns/logger.py | 10 ++++++++++
1 file changed, 10 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/ddns/logger.py b/src/lib/python/isc/ddns/logger.py
index e4f5ed8..9e92a9f 100644
--- a/src/lib/python/isc/ddns/logger.py
+++ b/src/lib/python/isc/ddns/logger.py
@@ -37,6 +37,13 @@ class ClientFormatter:
message is suppressed because of its log level (which is often the case
for debug messages).
+ Note: this optimization comes with the cost of instantiating the
+ formatter object itself. It's not really clear which overhead is
+ heavier, and we may conclude it's actually better to just generate
+ the strings unconditionally. Alternatively, we can make the stored
+ address of this object replaceable so that this object can be reused.
+ Right now this is an open issue.
+
"""
def __init__(self, addr):
self.__addr = addr
@@ -66,6 +73,9 @@ class ZoneFormatter:
message is suppressed because of its log level (which is often the case
for debug messages).
+ See the note for the ClientFormatter class about overhead tradeoff.
+ This class shares the same discussion.
+
"""
def __init__(self, zname, zclass):
self.__zname = zname
More information about the bind10-changes
mailing list