BIND 10 trac1455, updated. c73ca19a68d8e55dd3c07e4a92a4132f4f075892 [1455] Added notes about possible optimizations

[BIND 10 source code commits]

The branch, trac1455 has been updated
       via  c73ca19a68d8e55dd3c07e4a92a4132f4f075892 (commit)
      from  f621147e9399d1b8199dbe4be92e83f356c066b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c73ca19a68d8e55dd3c07e4a92a4132f4f075892
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri May 25 12:29:13 2012 +0200

    [1455] Added notes about possible optimizations
    
    As per review comment http://bind10.isc.org/ticket/1455#comment:15

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/ddns/logger.py  |    3 +++
 src/lib/python/isc/ddns/session.py |   12 ++++++++++++
 2 files changed, 15 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/ddns/logger.py b/src/lib/python/isc/ddns/logger.py
index f8a7f66..362b22b 100644
--- a/src/lib/python/isc/ddns/logger.py
+++ b/src/lib/python/isc/ddns/logger.py
@@ -89,6 +89,9 @@ class RRsetFormatter:
     This class is designed to delay the conversion until it's explicitly
     requested, so the conversion doesn't happen if the corresponding log
     message is suppressed because of its log level.
+
+    See the note for the ClientFormatter class about overhead tradeoff.
+    This class shares the same discussion.
     """
     def __init__(self, rrset):
         self.__rrset = rrset
diff --git a/src/lib/python/isc/ddns/session.py b/src/lib/python/isc/ddns/session.py
index 5374790..51da0e9 100644
--- a/src/lib/python/isc/ddns/session.py
+++ b/src/lib/python/isc/ddns/session.py
@@ -199,6 +199,12 @@ class UpdateSession:
            TTL, and Rdata (if any) of the given RRset are ignored.
            RFC2136 Section 2.4.1.
            Returns True if the prerequisite is satisfied, False otherwise.
+
+           Note: the only thing used in the call to find() here is the
+           result status. The actual data is immediately dropped. As
+           a future optimization, we may want to add a find() option to
+           only return what the result code would be (and not read/copy
+           any actual data).
         '''
         _, finder = datasrc_client.find_zone(rrset.get_name())
         result, _, _ = finder.find(rrset.get_name(), rrset.get_type(),
@@ -246,6 +252,12 @@ class UpdateSession:
            1 or more RRs).
            RFC2136 Section 2.4.4
            Returns True if the prerequisite is satisfied, False otherwise.
+
+           Note: the only thing used in the call to find_all() here is
+           the result status. The actual data is immediately dropped. As
+           a future optimization, we may want to add a find_all() option
+           to only return what the result code would be (and not read/copy
+           any actual data).
         '''
         _, finder = datasrc_client.find_zone(rrset.get_name())
         result, rrsets, flags = finder.find_all(rrset.get_name(),