BIND 10 trac1704_2, updated. 088760558f2321ea60b393b37fba0a672ce9f943 [1704] style matters: fold long lines, explicit virtual for inherited methods.

BIND 10 source code commits bind10-changes at lists.isc.org
Wed May 30 18:23:08 UTC 2012


The branch, trac1704_2 has been updated
       via  088760558f2321ea60b393b37fba0a672ce9f943 (commit)
      from  56c895c19be423403c0ddb84f25ea958af9cc371 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 088760558f2321ea60b393b37fba0a672ce9f943
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed May 30 11:22:45 2012 -0700

    [1704] style matters: fold long lines, explicit virtual for inherited methods.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/bind10/tests/bind10_test.py.in |    3 ++-
 src/lib/log/logger_impl.cc             |    3 ++-
 src/lib/log/tests/logger_lock_test.cc  |    6 +++---
 3 files changed, 7 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/bind10/tests/bind10_test.py.in b/src/bin/bind10/tests/bind10_test.py.in
index 6924dc9..5e5afba 100644
--- a/src/bin/bind10/tests/bind10_test.py.in
+++ b/src/bin/bind10/tests/bind10_test.py.in
@@ -1471,7 +1471,8 @@ class SocketSrvTest(unittest.TestCase):
 
 class TestFunctions(unittest.TestCase):
     def setUp(self):
-        self.lockfile_testpath = "@abs_top_builddir@/src/bin/bind10/tests/lockfile_test"
+        self.lockfile_testpath = \
+            "@abs_top_builddir@/src/bin/bind10/tests/lockfile_test"
         self.assertFalse(os.path.exists(self.lockfile_testpath))
         os.mkdir(self.lockfile_testpath)
         self.assertTrue(os.path.isdir(self.lockfile_testpath))
diff --git a/src/lib/log/logger_impl.cc b/src/lib/log/logger_impl.cc
index d53e57d..2d6c0f4 100644
--- a/src/lib/log/logger_impl.cc
+++ b/src/lib/log/logger_impl.cc
@@ -112,7 +112,8 @@ LoggerImpl::lookupMessage(const MessageID& ident) {
 void
 LoggerImpl::setInterprocessSync(isc::util::InterprocessSync* sync) {
     if (sync == NULL) {
-        isc_throw(BadInterprocessSync, "NULL was passed to setInterprocessSync()");
+        isc_throw(BadInterprocessSync,
+                  "NULL was passed to setInterprocessSync()");
     }
 
     delete sync_;
diff --git a/src/lib/log/tests/logger_lock_test.cc b/src/lib/log/tests/logger_lock_test.cc
index f5868a9..4621baf 100644
--- a/src/lib/log/tests/logger_lock_test.cc
+++ b/src/lib/log/tests/logger_lock_test.cc
@@ -30,17 +30,17 @@ public:
     {}
 
 protected:
-    bool lock() {
+    virtual bool lock() {
         cout << "FIELD1 FIELD2 LOGGER_LOCK_TEST: LOCK\n";
         return (true);
     }
 
-    bool tryLock() {
+    virtual bool tryLock() {
         cout << "FIELD1 FIELD2 LOGGER_LOCK_TEST: TRYLOCK\n";
         return (true);
     }
 
-    bool unlock() {
+    virtual bool unlock() {
         cout << "FIELD1 FIELD2 LOGGER_LOCK_TEST: UNLOCK\n";
         return (true);
     }



More information about the bind10-changes mailing list