BIND 10 trac2353, updated. 4a9b794019090fd826688bca0aee4dc565756cc1 [2353] Test BoB.init_socket_srv() and BoB.remove_socket_srv()
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Nov 7 05:01:29 UTC 2012
The branch, trac2353 has been updated
via 4a9b794019090fd826688bca0aee4dc565756cc1 (commit)
from 180a437742219f6266934738962663c65ab748f6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4a9b794019090fd826688bca0aee4dc565756cc1
Author: Mukund Sivaraman <muks at isc.org>
Date: Wed Nov 7 10:31:21 2012 +0530
[2353] Test BoB.init_socket_srv() and BoB.remove_socket_srv()
-----------------------------------------------------------------------
Summary of changes:
src/bin/bind10/bind10_src.py.in | 3 +++
src/bin/bind10/tests/bind10_test.py.in | 23 +++++++++++++++++++++++
2 files changed, 26 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/bin/bind10/bind10_src.py.in b/src/bin/bind10/bind10_src.py.in
index 2d31333..4c73b78 100755
--- a/src/bin/bind10/bind10_src.py.in
+++ b/src/bin/bind10/bind10_src.py.in
@@ -916,6 +916,9 @@ class BoB:
self._srv_socket.close()
os.remove(self._socket_path)
os.rmdir(self._tmpdir)
+ self._srv_socket = None
+ self._tmpdir = None
+ self._socket_path = None
def _srv_accept(self):
"""
diff --git a/src/bin/bind10/tests/bind10_test.py.in b/src/bin/bind10/tests/bind10_test.py.in
index 20e8b1f..18d0011 100644
--- a/src/bin/bind10/tests/bind10_test.py.in
+++ b/src/bin/bind10/tests/bind10_test.py.in
@@ -25,6 +25,7 @@ import bind10_src
import unittest
import sys
import os
+import os.path
import copy
import signal
import socket
@@ -366,6 +367,28 @@ class TestBoB(unittest.TestCase):
self.assertEqual(creator, bob._socket_cache._creator)
self.assertRaises(ValueError, bob.set_creator, creator)
+ def test_socket_srv(self):
+ """Tests init_socket_srv() and remove_socket_srv() work as expected."""
+ bob = BoB()
+
+ self.assertIsNone(bob._srv_socket)
+ self.assertIsNone(bob._tmpdir)
+ self.assertIsNone(bob._socket_path)
+
+ bob.init_socket_srv()
+
+ self.assertIsNotNone(bob._srv_socket)
+ self.assertIsNotNone(bob._tmpdir)
+ self.assertTrue(os.path.isdir(bob._tmpdir))
+ self.assertIsNotNone(bob._socket_path)
+ self.assertTrue(os.path.exists(bob._socket_path))
+
+ bob.remove_socket_srv()
+
+ self.assertIsNone(bob._srv_socket)
+ self.assertIsNone(bob._tmpdir)
+ self.assertIsNone(bob._socket_path)
+
def test_init_alternate_socket(self):
bob = BoB("alt_socket_file")
self.assertEqual(bob.verbose, False)
More information about the bind10-changes
mailing list