BIND 10 trac2463, updated. 43d61adcf5a876a3a5c76ba78ea4c980d7e70704 [2463] Minor changes in comments.
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Nov 8 16:24:04 UTC 2012
The branch, trac2463 has been updated
via 43d61adcf5a876a3a5c76ba78ea4c980d7e70704 (commit)
from 248da8cb1f68c93e411d3b1b22479acaaa255c15 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 43d61adcf5a876a3a5c76ba78ea4c980d7e70704
Author: Marcin Siodelski <marcin at isc.org>
Date: Thu Nov 8 17:23:49 2012 +0100
[2463] Minor changes in comments.
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp6/config_parser.cc | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp6/config_parser.cc b/src/bin/dhcp6/config_parser.cc
index e37a632..224eac0 100644
--- a/src/bin/dhcp6/config_parser.cc
+++ b/src/bin/dhcp6/config_parser.cc
@@ -565,15 +565,13 @@ public:
createOption();
}
- /// @brief Commits option values.
+ /// @brief Commits option value.
///
- /// This function iterates over all options configured for a particular
- /// subnet or globally and moves them to the storage. If there are any options
- /// already present in the storage they will be replaced if options with
- /// the same code are present in the intermediate storage.
+ /// This function adds new option to the storage or replaces existing option
+ /// with the same code.
///
- /// @throw isc::InvalidOperation if failed to set pointer to storage failed
- /// to call build() prior to commit. If that happens the data in the storage
+ /// @throw isc::InvalidOperation if failed to set pointer to storage or failed
+ /// to call build() prior to commit. If that happens data in the storage
/// remain not modified.
virtual void commit() {
if (options_ == NULL) {
@@ -802,6 +800,9 @@ public:
BOOST_FOREACH(ParserPtr parser, parsers_) {
parser->commit();
}
+ // Parsing was successful and we have all configured
+ // options in local storage. We can now replace old values
+ // with new values.
std::swap(local_options_, *options_);
}
@@ -814,7 +815,10 @@ public:
return (new OptionDataListParser(param_name));
}
- /// Intermediate option storage
+ /// Intermediate option storage. This storage is used by
+ /// lower level parsers to add new options. Values held
+ /// in this storage are assigned to main storage (options_)
+ /// if overall parsing was successful.
OptionStorage local_options_;
/// Pointer to options instances storage.
OptionStorage* options_;
More information about the bind10-changes
mailing list