BIND 10 trac2376, updated. 737fb65557c0473043a4e626e8b00b6fefbf2364 [2376] style fixes: added blank line before \brief
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Nov 8 21:58:29 UTC 2012
The branch, trac2376 has been updated
via 737fb65557c0473043a4e626e8b00b6fefbf2364 (commit)
from 487768796e6c8941c4b2399546de8b4161c06f63 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 737fb65557c0473043a4e626e8b00b6fefbf2364
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Thu Nov 8 13:58:14 2012 -0800
[2376] style fixes: added blank line before \brief
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/loader_context.h | 8 ++++++++
src/lib/dns/master_loader.h | 3 +++
2 files changed, 11 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/loader_context.h b/src/lib/datasrc/loader_context.h
index 7b6981a..d2ecc46 100644
--- a/src/lib/datasrc/loader_context.h
+++ b/src/lib/datasrc/loader_context.h
@@ -40,12 +40,14 @@ public:
/// (no changes done to it yet). It is up to the caller to commit or
/// rollback the updater after the loading is done.
LoaderContext(ZoneUpdater& updater);
+
/// \brief Adds a new rrset to the updater.
///
/// This is implementation of the interface's method.
///
/// \param rrset The rrset to add.
virtual void addRRset(const isc::dns::RRsetPtr& rrset);
+
/// \brief Return the problem-handling callbacks.
///
/// This is implementation of the interface's method.
@@ -55,6 +57,7 @@ public:
virtual isc::dns::LoaderCallbacks& getCallbacks() const {
return (callbacks_);
}
+
/// \brief Was the load successful?
///
/// \return True if the load was successful so far - which means no
@@ -62,13 +65,16 @@ public:
bool ok() const {
return (ok_);
}
+
private:
/// \brief Internal handler of error.
void handleError(const std::string& source, size_t line, size_t byte,
const std::string& reason);
+
/// \brief Internal handle of warning.
void handleWarning(const std::string& source, size_t line, size_t byte,
const std::string& reason);
+
/// \brief The callbacks to be returned.
///
/// They need to exist as a real variable. It also needs to be mutable,
@@ -76,8 +82,10 @@ private:
/// reference. It needs to be non-const, to be possible to call the
/// the actual callbacks (the operator() might be non-const).
mutable isc::dns::LoaderCallbacks callbacks_;
+
/// \brief The updater to be used.
ZoneUpdater& updater_;
+
/// \brief Was the load successful?
bool ok_;
};
diff --git a/src/lib/dns/master_loader.h b/src/lib/dns/master_loader.h
index bd9ba6d..497bd80 100644
--- a/src/lib/dns/master_loader.h
+++ b/src/lib/dns/master_loader.h
@@ -46,6 +46,7 @@ struct LoaderCallbacks {
size_t source_line,
size_t source_byte,
const std::string& reason)> Callback;
+
/// \brief Callback for serious errors
///
/// This is called whenever there's a serious problem which makes the data
@@ -56,6 +57,7 @@ struct LoaderCallbacks {
/// If the caller of the loader wants to abort, it is possible to throw
/// from the callback, which aborts the load.
Callback error;
+
/// \brief Callback for potential problems
///
/// This is called whenever a minor problem is discovered. This might mean
@@ -80,6 +82,7 @@ public:
///
/// The loader found another RRset and reports it by calling this method.
virtual void addRRset(const RRsetPtr& rrset) = 0;
+
/// \brief Get callbacks for error handling
///
/// The master loader accesses the callbacks used for error reporting
More information about the bind10-changes
mailing list