BIND 10 master, updated. 3f1afa7c181c802ba2dab143cc9b5f72e8e1de69 [master] define virtual dtor for master lexer state classes.

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Nov 14 03:54:08 UTC 2012


The branch, master has been updated
       via  3f1afa7c181c802ba2dab143cc9b5f72e8e1de69 (commit)
      from  9a11ef62ae36d9d891e87ba792fa249ae82f0736 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3f1afa7c181c802ba2dab143cc9b5f72e8e1de69
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Nov 13 19:53:18 2012 -0800

    [master] define virtual dtor for master lexer state classes.
    
    just for silencing some compilers.  in our usage this doesn't matter
    in practice.  committing at my discretion.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/master_lexer.cc      |    2 ++
 src/lib/dns/master_lexer_state.h |    6 ++++++
 2 files changed, 8 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/master_lexer.cc b/src/lib/dns/master_lexer.cc
index 992a051..0978a8f 100644
--- a/src/lib/dns/master_lexer.cc
+++ b/src/lib/dns/master_lexer.cc
@@ -170,6 +170,7 @@ namespace {
 class CRLF : public State {
 public:
     CRLF() {}
+    virtual ~CRLF() {}          // see the base class for the destructor
     virtual const State* handle(MasterLexer& lexer) const {
         // We've just seen '\r'.  If this is part of a sequence of '\r\n',
         // we combine them as a single END-OF-LINE.  Otherwise we treat the
@@ -195,6 +196,7 @@ public:
 class String : public State {
 public:
     String() {}
+    virtual ~String() {}      // see the base class for the destructor
     virtual const State* handle(MasterLexer& /*lexer*/) const {
         return (NULL);
     }
diff --git a/src/lib/dns/master_lexer_state.h b/src/lib/dns/master_lexer_state.h
index 86957c5..1130f33 100644
--- a/src/lib/dns/master_lexer_state.h
+++ b/src/lib/dns/master_lexer_state.h
@@ -55,6 +55,12 @@ namespace master_lexer_internal {
 /// this library are expected to use this class.
 class State {
 public:
+    /// \brief Virtual destructor.
+    ///
+    /// In our usage this actually doesn't matter, but some compilers complain
+    /// about it and we need to silence them.
+    virtual ~State() {}
+
     /// \brief Begin state transitions to get the next token.
     ///
     /// This is the first method that \c MasterLexer needs to call for a



More information about the bind10-changes mailing list