BIND 10 trac2459, updated. 8f4e6ef30b3078b8720b618efdacfb4fb186ad9f [2459] some more comments about datasrc locking. suggested by muks.

[BIND 10 source code commits]

The branch, trac2459 has been updated
       via  8f4e6ef30b3078b8720b618efdacfb4fb186ad9f (commit)
      from  38880a0a12721118c423dee2396ccfd165b103d0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8f4e6ef30b3078b8720b618efdacfb4fb186ad9f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Nov 13 22:09:22 2012 -0800

    [2459] some more comments about datasrc locking.  suggested by muks.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/auth/auth_srv.cc |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/auth/auth_srv.cc b/src/bin/auth/auth_srv.cc
index dca8fd0..26a8489 100644
--- a/src/bin/auth/auth_srv.cc
+++ b/src/bin/auth/auth_srv.cc
@@ -651,9 +651,10 @@ AuthSrvImpl::processNormalQuery(const IOMessage& io_message, Message& message,
         local_edns->setUDPSize(AuthSrvImpl::DEFAULT_LOCAL_UDPSIZE);
         message.setEDNS(local_edns);
     }
-    // Get access to data source client list through the holder and keep the
-    // holder until the processing and rendering is done to avoid inter-thread
-    // race.
+
+    // Get access to data source client list through the holder and keep
+    // the holder until the processing and rendering is done to avoid
+    // race with any other thread(s) such as the background loader.
     auth::DataSrcClientsMgr::Holder datasrc_holder(datasrc_clients_mgr_);
 
     try {
@@ -688,6 +689,9 @@ AuthSrvImpl::processNormalQuery(const IOMessage& io_message, Message& message,
     return (true);
     // The message can contain some data from the locked resource. But outside
     // this method, we touch only the RCode of it, so it should be safe.
+
+    // Lock on datasrc_clients_mgr_ acquired by datasrc_holder is
+    // released here upon its deletion.
 }
 
 bool