BIND 10 trac2373, updated. 377f14a32c7f86653f7c0e1f1217387fda38d6d2 [2373] added a comment about if-else complexity in State::start().
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Nov 19 03:19:15 UTC 2012
The branch, trac2373 has been updated
via 377f14a32c7f86653f7c0e1f1217387fda38d6d2 (commit)
from 843eaa0b842b335139c75f96275edc467bf6d7e6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 377f14a32c7f86653f7c0e1f1217387fda38d6d2
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Mon Nov 19 12:19:02 2012 +0900
[2373] added a comment about if-else complexity in State::start().
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/master_lexer.cc | 3 +++
1 file changed, 3 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/master_lexer.cc b/src/lib/dns/master_lexer.cc
index 185df8b..e50b75d 100644
--- a/src/lib/dns/master_lexer.cc
+++ b/src/lib/dns/master_lexer.cc
@@ -270,6 +270,9 @@ State::start(MasterLexer& lexer, MasterLexer::Options options) {
MasterLexer::MasterLexerImpl& lexerimpl = *lexer.impl_;
size_t& paren_count = lexerimpl.paren_count_;
+ // Note: the if-else in the loop is getting complicated. When we complete
+ // #2374, revisit the organization to see if we need a fundamental
+ // refactoring.
while (true) {
const int c = lexerimpl.skipComment(lexerimpl.source_->getChar());
if (c == InputSource::END_OF_STREAM) {
More information about the bind10-changes
mailing list