BIND 10 trac2353, updated. f6c776bc4a3cea0eae628d1580ab10843be06dfe [2353] Update comments
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Nov 19 22:30:09 UTC 2012
The branch, trac2353 has been updated
via f6c776bc4a3cea0eae628d1580ab10843be06dfe (commit)
from bc4926dac23a819a909992abf58df64d62647c68 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f6c776bc4a3cea0eae628d1580ab10843be06dfe
Author: Mukund Sivaraman <muks at isc.org>
Date: Tue Nov 20 03:59:38 2012 +0530
[2353] Update comments
-----------------------------------------------------------------------
Summary of changes:
src/bin/bind10/tests/bind10_test.py.in | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/bind10/tests/bind10_test.py.in b/src/bin/bind10/tests/bind10_test.py.in
index 833ea15..5af8348 100644
--- a/src/bin/bind10/tests/bind10_test.py.in
+++ b/src/bin/bind10/tests/bind10_test.py.in
@@ -1886,7 +1886,7 @@ class TestBossComponents(unittest.TestCase):
def socket_consumer_dead(self, sock):
self.dead.append(sock.fd)
- # All is well case
+ # Case where we get data every time we call recv()
bob = MockBobSocketData(False)
bob._socket_data(42)
self.assertEqual(bob.requests,
@@ -1895,8 +1895,9 @@ class TestBossComponents(unittest.TestCase):
self.assertEqual(bob.dead, [42])
self.assertFalse(bob._unix_sockets)
- # Case where socket raises EAGAIN. In this case, the routine is
- # supposed to save what it has back to BoB._unix_sockets.
+ # Case where socket.recv() raises EAGAIN. In this case, the
+ # routine is supposed to save what it has back to
+ # BoB._unix_sockets.
bob = MockBobSocketData(True)
bob._socket_data(42)
self.assertEqual(bob.requests, [{42: b'Hello World.'}])
@@ -1923,7 +1924,9 @@ class TestBossComponents(unittest.TestCase):
def kill_started_components(self):
self.killed = True
- # All is well case
+ # All is well case, where all components are started
+ # successfully. We check that the actual call to
+ # start_all_components() is made, and BoB.runnable is true.
bob = MockBobStartup(False)
r = bob.startup()
self.assertIsNone(r)
@@ -1931,7 +1934,9 @@ class TestBossComponents(unittest.TestCase):
self.assertFalse(bob.killed)
self.assertTrue(bob.runnable)
- # Case where starting all components fails
+ # Case where starting components fails. We check that
+ # kill_started_components() is called right after, and
+ # BoB.runnable is not modified.
bob = MockBobStartup(True)
r = bob.startup()
# r contains an error message
More information about the bind10-changes
mailing list