BIND 10 trac2157_2, updated. bb6e5acc09639be9a9009f3d266435aee2b0fce2 [2157] update doxygen, remove extra header includes
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Nov 26 02:29:42 UTC 2012
The branch, trac2157_2 has been updated
via bb6e5acc09639be9a9009f3d266435aee2b0fce2 (commit)
from 2ac23d0d571713a390d154263040c1f1290bba89 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bb6e5acc09639be9a9009f3d266435aee2b0fce2
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date: Mon Nov 26 11:28:44 2012 +0900
[2157] update doxygen, remove extra header includes
-----------------------------------------------------------------------
Summary of changes:
src/bin/auth/auth_srv.h | 2 +-
src/bin/auth/statistics.cc.pre | 1 -
src/bin/auth/statistics.h | 19 ++++++-------------
src/bin/auth/tests/statistics_unittest.cc.pre | 2 --
4 files changed, 7 insertions(+), 17 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/auth/auth_srv.h b/src/bin/auth/auth_srv.h
index 781b2b9..05e662d 100644
--- a/src/bin/auth/auth_srv.h
+++ b/src/bin/auth/auth_srv.h
@@ -204,7 +204,7 @@ public:
/// \brief Returns statistics data
///
/// This function can throw an exception from
- /// Counters::getStatistics().
+ /// Counters::get().
///
/// \return JSON format statistics data.
isc::data::ConstElementPtr getStatistics() const;
diff --git a/src/bin/auth/statistics.cc.pre b/src/bin/auth/statistics.cc.pre
index 4a9996b..bed965c 100644
--- a/src/bin/auth/statistics.cc.pre
+++ b/src/bin/auth/statistics.cc.pre
@@ -20,7 +20,6 @@
#include <dns/rcode.h>
#include <cc/data.h>
-#include <cc/session.h>
#include <algorithm>
#include <cctype>
diff --git a/src/bin/auth/statistics.h b/src/bin/auth/statistics.h
index 07812ee..bbf087b 100644
--- a/src/bin/auth/statistics.h
+++ b/src/bin/auth/statistics.h
@@ -15,7 +15,6 @@
#ifndef __STATISTICS_H
#define __STATISTICS_H 1
-#include <cc/session.h>
#include <cc/data.h>
#include <dns/message.h>
@@ -194,27 +193,21 @@ public:
/// \brief Set of DNS message counters.
///
-/// \c Counters is set of DNS message counters class. It holds DNS message
+/// \c Counters is a set of DNS message counters class. It holds DNS message
/// counters and provides an interface to increment the counter of specified
/// type (e.g. UDP message, TCP message).
///
-/// This class also provides a function to send statistics information to
-/// statistics module.
-///
/// This class is designed to be a part of \c AuthSrv.
/// Call \c inc() to increment a counter for the message.
-/// Call \c getStatistics() to answer statistics information to statistics
-/// module with statistics_session, when the command \c getstats is received.
+/// Call \c get() to get a set of DNS message counters.
///
/// We may eventually want to change the structure to hold values that are
/// not counters (such as concurrent TCP connections), or seperate generic
/// part to src/lib to share with the other modules.
///
-/// This class uses pimpl idiom and hides detailed implementation.
/// This class is constructed on startup of the server, so
/// construction overhead of this approach should be acceptable.
///
-/// \todo Hold counters for each message types (Notify, Axfr, Ixfr, Normal)
/// \todo Consider overhead of \c Counters::inc()
class Counters : boost::noncopyable {
private:
@@ -248,8 +241,8 @@ public:
/// \brief Increment counters according to the parameters.
///
- /// This constructor is mostly exception free. But it may still throw
- /// a standard exception if memory allocation fails inside the method.
+ /// This method is mostly exception free. But it may still throw a
+ /// standard exception if memory allocation fails inside the method.
///
/// \param msgattrs DNS message attributes.
/// \param response DNS response message.
@@ -262,8 +255,8 @@ public:
/// \brief Get statistics counters.
///
- /// This method is mostly exception free. But it may still throw
- /// a standard exception if memory allocation fails inside the method.
+ /// This method is mostly exception free. But it may still throw a
+ /// standard exception if memory allocation fails inside the method.
///
/// \return statistics data
///
diff --git a/src/bin/auth/tests/statistics_unittest.cc.pre b/src/bin/auth/tests/statistics_unittest.cc.pre
index 6599853..5f5f6ca 100644
--- a/src/bin/auth/tests/statistics_unittest.cc.pre
+++ b/src/bin/auth/tests/statistics_unittest.cc.pre
@@ -23,7 +23,6 @@
#include <dns/rrttl.h>
#include <cc/data.h>
-#include <cc/session.h>
#include <auth/statistics.h>
#include <auth/statistics_items.h>
@@ -40,7 +39,6 @@
#include <netdb.h>
using namespace std;
-using namespace isc::cc;
using namespace isc::dns;
using namespace isc::data;
using namespace isc::auth::statistics;
More information about the bind10-changes
mailing list