BIND 10 trac2365, updated. 31b4c8a77f74ff4f417171af1ceb428c134572a3 [2365] Added todo comments for added functions.
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Nov 28 09:57:38 UTC 2012
The branch, trac2365 has been updated
via 31b4c8a77f74ff4f417171af1ceb428c134572a3 (commit)
from 0c58aace22046e4e58360df79299150b745994a4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 31b4c8a77f74ff4f417171af1ceb428c134572a3
Author: Marcin Siodelski <marcin at isc.org>
Date: Wed Nov 28 10:57:23 2012 +0100
[2365] Added todo comments for added functions.
-----------------------------------------------------------------------
Summary of changes:
src/lib/dhcp/option.h | 10 ++++++++++
1 file changed, 10 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/option.h b/src/lib/dhcp/option.h
index 963f935..a6b0622 100644
--- a/src/lib/dhcp/option.h
+++ b/src/lib/dhcp/option.h
@@ -320,6 +320,11 @@ protected:
/// derived classes that override pack.
///
/// @param [out] buf output buffer.
+ ///
+ /// @todo The set of exceptions thrown by this function depend on
+ /// exceptions thrown by pack methods invoked on objects
+ /// representing sub options. We should consider whether to aggregate
+ /// those into one exception which can be documented here.
void packOptions(isc::util::OutputBuffer& buf);
/// @brief Builds a collection of sub options from the buffer.
@@ -329,6 +334,11 @@ protected:
/// different exceptions when option assembly fails.
///
/// @param buf buffer to be parsed.
+ ///
+ /// @todo The set of exceptions thrown by this function depend on
+ /// exceptions thrown by unpack methods invoked on objects
+ /// representing sub options. We should consider whether to aggregate
+ /// those into one exception which can be documented here.
void unpackOptions(const OptionBuffer& buf);
/// @brief A private method used for option correctness.
More information about the bind10-changes
mailing list