BIND 10 trac2506, created. d4b9c33282199c912e6f795f6bbfddde12510795 [2506] (unrelated) cleanup: define ReadError as a class, not a struct.

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Nov 29 21:31:43 UTC 2012


The branch, trac2506 has been created
        at  d4b9c33282199c912e6f795f6bbfddde12510795 (commit)

- Log -----------------------------------------------------------------
commit d4b9c33282199c912e6f795f6bbfddde12510795
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 13:29:02 2012 -0800

    [2506] (unrelated) cleanup: define ReadError as a class, not a struct.
    
    for consistency; it's awkward to see it as a struct while LexerError as a
    .class.
    
    The choice is basically a matter of taste, but I personally think it's
    better to be defined as a class as its base is defined as a class, and
    these exception structs are not just a trivial set of values.

commit d27729277c9e4c9bb4cf121700d67181d6c0aadc
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 13:28:20 2012 -0800

    [2506] documentation update

commit 09cd4b9b32415144a2542171558b56226322bd7e
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 10:54:54 2012 -0800

    [2506] handle other rare error cases

commit 597ed99f869f9d170c93467e8abcc2b03959f75f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 10:40:28 2012 -0800

    [2506] handled the case when getNextToken expects a number but it's too big.

commit ae3a1e5d17d5c8ab8c9dcf20cf60a68744f5cca0
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 10:28:26 2012 -0800

    [2506] handled the case a number is expected but not found

commit d52186367e1f8b49dcb5a3b4825841a95251412f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 10:14:01 2012 -0800

    [2506] supported NUMBER in getNextToken() with expected type

commit f70d131fd20085a472de32f86299a77647f18fd5
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 10:06:01 2012 -0800

    [2506] resolved remaining conflicts on rebase

commit b991213a389213fe42ef0c87bde56e462c025229
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Thu Nov 29 09:59:54 2012 -0800

    [2506] added another version of getNextToken, basic part

commit c6c7cdee4088d6be3728ffaf07a25b920b0e8b5c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Nov 28 15:12:28 2012 -0800

    [2506] rename: MasterLexer::Token to MasterToken.
    
    it's a kind of hack for the convenience of the planned change of this branch,
    but the revised name doesn't seem really bad anyway.

commit ebea1d79bcd55536f89e250ce1be13a8369171f7
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Nov 28 14:49:19 2012 -0800

    [2506] updated part of lexer state doc to match the latest changes.

commit 610720a5bef22ba7193c9ad6e3cbe318eebdbf14
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Nov 28 14:37:23 2012 -0800

    [2506] removed meaningless comment
    
    this is remaining open point from #2375.  The comment was added at
    commit 33a3143, and it's been the same since the introduction.
    Aside from the fact that the sentence is incomplete, IMO the comment doesn't
    provide any meaningful information; it's obvious that "the source is not
    available" if source_ is NULL.  Even if we complete the sentence by
    adding, e.g, "(then) throw InvalidOperation", it still doesn't provide
    any additional information than the code itself.
    
    So my decision is to to simply clean it up.

-----------------------------------------------------------------------



More information about the bind10-changes mailing list