BIND 10 trac2497, updated. 25f65134a9058c888a4181ba413ec1756e6b1d45 [2497] Add tests for HINFO, MINFO and NAPTR rrtypes

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Nov 30 04:01:56 UTC 2012


The branch, trac2497 has been updated
       via  25f65134a9058c888a4181ba413ec1756e6b1d45 (commit)
      from  5c8cd4010e950d6d0aa68586252c5a3039e5a248 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 25f65134a9058c888a4181ba413ec1756e6b1d45
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Nov 30 09:31:39 2012 +0530

    [2497] Add tests for HINFO, MINFO and NAPTR rrtypes

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/tests/rdata_hinfo_unittest.cc |   13 +++++++++++++
 src/lib/dns/tests/rdata_minfo_unittest.cc |    6 ++++++
 src/lib/dns/tests/rdata_naptr_unittest.cc |   15 +++++++++++++++
 3 files changed, 34 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/tests/rdata_hinfo_unittest.cc b/src/lib/dns/tests/rdata_hinfo_unittest.cc
index c934a4f..597c43d 100644
--- a/src/lib/dns/tests/rdata_hinfo_unittest.cc
+++ b/src/lib/dns/tests/rdata_hinfo_unittest.cc
@@ -77,6 +77,19 @@ TEST_F(Rdata_HINFO_Test, createFromWire) {
     EXPECT_EQ(string("Linux"), hinfo.getOS());
 }
 
+TEST_F(Rdata_HINFO_Test, createFromLexer) {
+    HINFO rdata_hinfo(hinfo_str);
+    EXPECT_EQ(0, rdata_hinfo.compare(
+        *test::createRdataUsingLexer(RRType::HINFO(), RRClass::IN(),
+                                     hinfo_str)));
+
+    // Check that bad input throws as usual
+    EXPECT_THROW({
+        *test::createRdataUsingLexer(RRType::HINFO(), RRClass::IN(),
+                                     "\"Pentium\"\"Linux\"");
+    }, InvalidRdataText);
+}
+
 TEST_F(Rdata_HINFO_Test, toText) {
     HINFO hinfo(hinfo_str);
     EXPECT_EQ(hinfo_str, hinfo.toText());
diff --git a/src/lib/dns/tests/rdata_minfo_unittest.cc b/src/lib/dns/tests/rdata_minfo_unittest.cc
index 78e8325..2f717fe 100644
--- a/src/lib/dns/tests/rdata_minfo_unittest.cc
+++ b/src/lib/dns/tests/rdata_minfo_unittest.cc
@@ -103,6 +103,12 @@ TEST_F(Rdata_MINFO_Test, createFromWire) {
                  DNSMessageFORMERR);
 }
 
+TEST_F(Rdata_MINFO_Test, createFromLexer) {
+    EXPECT_EQ(0, rdata_minfo.compare(
+        *test::createRdataUsingLexer(RRType::MINFO(), RRClass::IN(),
+                                     minfo_txt)));
+}
+
 TEST_F(Rdata_MINFO_Test, assignment) {
     generic::MINFO copy((string(minfo_txt2)));
     copy = rdata_minfo;
diff --git a/src/lib/dns/tests/rdata_naptr_unittest.cc b/src/lib/dns/tests/rdata_naptr_unittest.cc
index 5abcaef..7a6df49 100644
--- a/src/lib/dns/tests/rdata_naptr_unittest.cc
+++ b/src/lib/dns/tests/rdata_naptr_unittest.cc
@@ -128,6 +128,21 @@ TEST_F(Rdata_NAPTR_Test, createFromWire) {
     EXPECT_EQ(Name("_sip._udp.example.com."), naptr.getReplacement());
 }
 
+TEST_F(Rdata_NAPTR_Test, createFromLexer) {
+    NAPTR rdata_naptr(naptr_str);
+
+    EXPECT_EQ(0, rdata_naptr.compare(
+        *test::createRdataUsingLexer(RRType::NAPTR(), RRClass::IN(),
+                                     naptr_str)));
+
+    // Check that bad input throws as usual (order > 65535)
+    EXPECT_THROW({
+        *test::createRdataUsingLexer(RRType::NAPTR(), RRClass::IN(),
+                                     "65536 10 S SIP \"\" "
+                                     "_sip._udp.example.com.");
+    }, InvalidRdataText);
+}
+
 TEST_F(Rdata_NAPTR_Test, toWire) {
     NAPTR naptr(naptr_str);
     naptr.toWire(obuffer);



More information about the bind10-changes mailing list